1618669 - PID available in crashreport?

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P3)

Description

[Michael Froman [:mjf]]

It is possible that I'm overlooking something, or don't know where to look, but I can't find the PID of the crashed process in the crash dump on try. Ex:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285427933&repo=mozilla-central&lineNumber=39342

I can deduce from the stack trace that we're in a content process, but I'm having trouble figuring out which content process crashed since one is in the process of going away, and one is in the process of starting work.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

The minidump contains the crashed process PID. If you download it and feed it to minidump_dump you can see it. In this case for example:

$ minidump_dump 9511d927-9b59-44b6-9614-3c94f55e6c96.dmp 2>/dev/null | grep process_id
  process_id                   = 11836

However I don't think we surface it in any other way. It would be a matter of modifying the minidump_stackwalker tool used in automation to dump it out.

Comment 2

[Michael Froman [:mjf]]

(In reply to Gabriele Svelto [:gsvelto] from comment #1)

The minidump contains the crashed process PID. If you download it and feed it to minidump_dump you can see it. In this case for example:

$ minidump_dump 9511d927-9b59-44b6-9614-3c94f55e6c96.dmp 2>/dev/null | grep process_id
  process_id                   = 11836

However I don't think we surface it in any other way. It would be a matter of modifying the minidump_stackwalker tool used in automation to dump it out.

I have no experience w/ minidump_dump and which minidump_dump doesn't turn up anything. Where do I find it?

It does seem like having it printed out in automation would be a nice solution.

Comment 3

[Michael Froman [:mjf]]

Sorry - I found instructions here: https://chromium.googlesource.com/breakpad/breakpad/

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Yeah it's not super-simple, it would be best to have it in the test log directly.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

Putting it in the right component and setting it to P3. Will, I'll work on this as soon as I'll have time since it requires changes to the stack walker to spit out this information when analyzing a dump.

Comment 7

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1618669 - Display tid of crashing thread in minidump_stackwalk output. r=sfink

Comment 8

[Gabriele Svelto [:gsvelto] (PTO)]

Steve, do you want me to pick up the patch and finish it?

Comment 9

[Steve Fink [:sfink] [:s:]]

(In reply to Gabriele Svelto [:gsvelto] from comment #8)

Steve, do you want me to pick up the patch and finish it?

Yes, please do!

Comment 10

[Gabriele Svelto [:gsvelto] (PTO)]

Cool, stealing this bug :-)

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm not sure I understand this bug. It's a bug in the socorro processor, but the attached patch is against the crash reporter. Is the PID not available in the minidump for minidump-stackwalk to extract or is there other work being done here?

If it's work that needs to be done in minidump-stackwalk, we should probably have an issue in either of those repos:

• https://github.com/mozilla-services/minidump-stackwalk/issues
• https://github.com/luser/rust-minidump/issues

Comment 12

[Gabriele Svelto [:gsvelto] (PTO)]

It's about minidump-stackwalk but not the version we use in Socorro, it's about the version in m-c. I miscategorized this one, moving it back to crash reporting.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4b960c51c4b
Display tid of crashing thread in minidump_stackwalk output. r=sfink

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a4b960c51c4b