1618759 - [TSF][IMM] Update inputmode support type per current spec on Windows

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

We will update values via bug 1509527.

Also, we have typos such as https://searchfox.org/mozilla-central/rev/b2ccce862ef38d0d150fcac2b597f7f20091a0c7/widget/windows/TSFTextStore.cpp#3993

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Moving all open keyboard/IME handling bugs to DOM: UI Events & Focus Handling component.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that you need to update IMEHandler::SetInputScopeForIMM32() too.
https://searchfox.org/mozilla-central/rev/202a285024f174c2d2bf2152d9cba90a03723eab/widget/windows/WinIMEHandler.cpp#637

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #2)

I think that you need to update IMEHandler::SetInputScopeForIMM32() too.
https://searchfox.org/mozilla-central/rev/202a285024f174c2d2bf2152d9cba90a03723eab/widget/windows/WinIMEHandler.cpp#637

Yes, I will clean up this since this is duplicated code.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1618759 - Part 1. Use common method to set input scope. r=masayuki

Gecko has duplicated code for input scope support, so I would like to clean up
this.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1618759 - Part 2. Support decimal and search value for inputmode. r=masayuki

Current WHATWG spec means that numeric is IS_DIGITS and decimal is
IS_NUMBER.

Depends on D68312

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1618759 - Part 3. Allow inputmode for non-input element. r=masayuki

Current WHATWG spec is that inputmode attribute supports non-input element.
I would like to remove input element check for bug 142484 that is
contenteditable support.

Depends on D68313

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1618759 - Part 4. Use InputPane to open on-screen keyboard for Windows 10 RS1+. r=masayuki

Unfortunately, current on-screen keyboard (OSK) code in Gecko doesn't work on
current Windows 10. Actually, Windows automatically control OSK when getting
focus. But this isn't good for web browser since inputmode spec can close
OSK by none value.

Windows 10 RS1 has new API (IInputPane [*1]) to control software keyboard. So
we have to use it if OS is RS1 or later.

TSF has new flag as TS_SD_INPUTPANEMANUALDISPLAYENABLE not to control OSK by
TSF. We should use it.

IMM doesn't have this feature to manage OSK. This will become a limitation for
inputmode implementation.

[*1] https://docs.microsoft.com/en-us/uwp/api/windows.ui.viewmanagement.inputpane

Depends on D68314

Comment 8

[Makoto Kato [:m_kato]]

Attachment: Bug 1618759 - Part 5. Lazy check whether OSK is closed. r=masayuki

As long as I test on my environment, bug 1226148 isn't fixed. Since native
message queue is high priority, Gecko may check whether focus is changed
before changing focus to another.

So we shouldn't use native message queue for this. It is better to use idle
queue instead.

Depends on D68315

Comment 9

[Makoto Kato [:m_kato]]

Attachment: Bug 1618759 - Part 6. Don't open on-screen keyboard when inputmode is none. r=masayuki

inputmode=none means that OSK is closed.

SetInputContext doesn't call DismissOnScreenKeyboard directly since
DismissOnScreenKeyboard has no hack of Firefox VR.

Depends on D68316

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/010d99db9abd
Part 1. Use common method to set input scope. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/a4dcd48616d9
Part 2. Support decimal and search value for inputmode. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0e3a40bf9ba8
Part 3. Allow inputmode for non-input element. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/020258996c4a
Part 4. Use InputPane to open on-screen keyboard for Windows 10 RS1+. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/f06a8ee813cf
Part 5. Lazy check whether OSK is closed. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/77a93a01f924
Part 6. Don't open on-screen keyboard when inputmode is none. r=masayuki

Comment 11

[Alexandru Michis [:malexandru]]

Backed out 6 changesets for causing mingw bustages on TSFTextStore.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/95735f5f18e039cbe9f77f863a50f4b4c27f556b

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=676749&tochange=670150d0ab6626a805f6a1be61531c01bbdbc8be&searchStr=mingw&fromchange=123eb94bd14d9f8073ab23e674ca0500c88e40d7&selectedJob=296609787

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296609787&repo=autoland&lineNumber=70742

Comment 12

[Makoto Kato [:m_kato]]

passed.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4efc5bdcbe6ce9d0137f3826ca783ce529de91b6

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e93a09256cf
Part 1. Use common method to set input scope. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/d093998cd803
Part 2. Support decimal and search value for inputmode. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/16ece38ec547
Part 3. Allow inputmode for non-input element. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/a08598089a5e
Part 4. Use InputPane to open on-screen keyboard for Windows 10 RS1+. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/662d50adf92a
Part 5. Lazy check whether OSK is closed. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3c9c7960f75f
Part 6. Don't open on-screen keyboard when inputmode is none. r=masayuki

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0e93a09256cf
https://hg.mozilla.org/mozilla-central/rev/d093998cd803
https://hg.mozilla.org/mozilla-central/rev/16ece38ec547
https://hg.mozilla.org/mozilla-central/rev/a08598089a5e
https://hg.mozilla.org/mozilla-central/rev/662d50adf92a
https://hg.mozilla.org/mozilla-central/rev/3c9c7960f75f