Closed
Bug 1618782
Opened 4 years ago
Closed 4 years ago
Windows cross builds are missing binscope
Categories
(Firefox Build System :: General, task, P3)
Firefox Build System
General
Tracking
(firefox76 fixed)
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(3 files)
Related: bug 1450088
|
||
Updated•4 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•4 years ago
|
Blocks: ship-win-cross
|
|
Assignee | |
Comment 1•4 years ago
|
||
We only enabled hardening with an explicit --enable-hardening because we
needed a patch. That patch was applied to upstream clang 8.0.1, so we
can now enable automatically whenever using the right version.
The explicit --enable-hardening was also not applied to win64-aarch64
debug builds, and this indirectly enables it there too, matching other
debug builds. This also avoids breaking debug builds when enabling
winchecksec on cross builds.
|
||
Updated•4 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/f06c58de6561 Enable hardening on win64-aarch64 build when the compiler supports it. r=rstewart https://hg.mozilla.org/integration/autoland/rev/baab1f9bd599 Use winchecksec on Windows cross builds too. r=rstewart
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f06c58de6561
https://hg.mozilla.org/mozilla-central/rev/baab1f9bd599
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
|
||
Comment 5•4 years ago
|
||
Pushed by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/2e5d02a2ef8a Fix l10n win AArch64 bustages. r=glandium a=l10n-bustage-fix
You need to log in
before you can comment on or make changes to this bug.
Description
•