1618870 - The “Collection” section is wrongly dismissed when a collection card is dismissed, archived, or deleted from Pocket

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Robert Martin [:romartin], Ecosystem QA]

Attachment: 2020-02-28_15h55_44.gif

[Affected versions]:

• Firefox Nightly 75.0a1 Build ID: 20200228092428

[Affected Platforms]:

• Windows 10 x64
• macOS 10.15
• Arch Linux 5.3.6 x64

[Prerequisites]:

• Have the value of the pref browser.newtabpage.activity-stream.discoverystream.endpoints set to http,https.
• Have the value of the pref browser.newtabpage.activity-stream.discoverystream.config set to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":true,"layout_endpoint":"https://e5e8374d-fffa-4a77-a604-31603852b6fd.mock.pstmn.io/1615081-layout"}.
• Have the value of the pref browser.search.region set to US.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab and hover a card from the “Collection” section.
3. Click the “Open menu” button and select the “Dismiss” option.
4. Observe the “Collection” section.

[Expected result]:

• The “Collection” section only has 2 cards left and the dismissed card disappears.

[Actual result]:

• The “Collection” section is completely dismissed.

[Notes]:

• This issue is also reproducible if the “Archive to pocket” or “Delete from Pocket” options are selected instead.
• If a “Sponsored Card” from the “Recommended by Pocket” section that has a URL shared with a card from the “Collection” section is dismissed, archived, or deleted from Pocket, the whole “Collection” section is dismissed.
• Attached a screen recording of the issue.

Comment 1

[Scott [:thecount] Downe]

There is a product decision to not display collections with less than 3 items, so initially this test was going to be done with only 3 items, meaning if you dismiss even 1, you end removing the whole collection.

We also had an issue where each item was the same flight_id, which is what we dismiss spnsored content on. So if you dismissed 1, all would go.

We've remedied this by increasing the number of items in the inventory (only 3 are shown, out of 5 or 6).

We've also ensured each item is using a different flight_id.

With these two fixes, you would need to dismiss 3 items, and then the whole section would then go away.

Comment 2

[Tawanda Kanhema]

We'll update when this feature is ready for QA

Comment 3

[Jessilyn Davis]

Scott - are we ready for QA to reQA this with the changes from #c1 ?

Comment 4

[Scott [:thecount] Downe]

Yup, should be good to go now.

Comment 5

[Robert Martin [:romartin], Ecosystem QA]

Hey @Scott,
Given the product decision mentioned in comment 1, we’ve revisited this scenario and found the following:

[Prerequisites]:

• Have the value of the pref browser.newtabpage.activity-stream.discoverystream.spocs-endpoint set to https://spocs.getpocket.com/spocs?site=1116390.
• Have the value of the pref browser.search.region set to US.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and open a new tab.
2. Open a new tab and hover a card from the “Collection Promo” section.
3. Click the “Open menu” button and select the “Dismiss” option.
4. Observe the “Collection” section.

[Expected result]:

• The dismissed card is no longer displayed and a new one from the queue has taken its place.

[Actual result]:

• The “Collections Promo” section is dismissed.

After finalizing the above scenario it is possible for the “Collection Promo” to be redisplayed. See bug 1620283. Can you please take a look at this?

Comment 6

[Scott [:thecount] Downe]

I can confirm the above, both that, and Bug 1620283 are good catches.

I'll look into both, and if related, fix both in 1620283.

Thanks for catching!

Comment 7

[Scott [:thecount] Downe]

Bug 1620283 is fixed, hoping to be in nightly tomorrow, and I was able to fix both issues in there.

Comment 8

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that this issue is no longer reproducible on Nightly 75.0a1 (Build ID: 20200309091841) on Windows 10 x64, Mac 10.15, Mint 19.2 Tina.
The prefs were those used in the experiment:

• Browser.newtabpage.activity-stream.discoverystream.spocs-endpoint set to https://spocs.getpocket.com/spocs?site=1116390&country=US&region=US-CA.
• Browser.search.region set to US.
  Dismissing, saving to Pocket, archiving or deleting a single card from Pocket no longer dismisses the section.

However, we noticed that this issue was still reproducible using the setup initially received for the feature:

• browser.newtabpage.activity-stream.discoverystream.endpoints set to http,https.
• browser.newtabpage.activity-stream.discoverystream.config set to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":true,"layout_endpoint":"https://e5e8374d-fffa-4a77-a604-31603852b6fd.mock.pstmn.io/1615081-layout"}.
• browser.search.region set to US.

Also, the cards for the feature are different from those used in the experiment, which makes us think the feature setup is now obsolete.

@Scott, could you please confirm that we should use the experiment setup from now on?

Comment 9

[Scott [:thecount] Downe]

Correct, we should be using the experiment setup endpoint from now on.

Comment 10

[Maria Heres, inactive, contact Ecosystem QA]

Considering the previous comment, I can confirm that the issue is no longer reproducible using Firefox Nightly 76.0a1 (Build ID: 20200310094445) and Firefox Beta 75.01b (Build ID: 20200309155231) on Windows 10 x64, Mac 10.15, Mint 19.2 Tina.
Dismissing, saving to Pocket, archiving or deleting a single card from Pocket no longer dismisses the section.
@Scott, do you think we can close this issue?

Comment 11

[Scott [:thecount] Downe]

Yup, we can close this. Fixed in bug 1620283

Comment 12

[Maria Heres, inactive, contact Ecosystem QA]

Based on comment 10, I am marking this issue as VERIFIED.