[PATCH] incorrect regexp in ConvertRGBColorIntoHEXColor()

RESOLVED FIXED

Status

SeaMonkey
Composer
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: glazou, Assigned: glazou)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

16 years ago
The regexp in ConvertRGBColorIntoHEXColor() in file editorUtilities.js in
incorrect. A recent change (or regression) in regexps showed it yesterday.

    /rgb\((\d*),*(\d*),*(\d*)\)/

should be read

    /rgb\((\d*),\s*(\d*),\s*(\d*)\)/

to accept whitespaces after the commas.
(Assignee)

Comment 1

16 years ago
Created attachment 94619 [details] [diff] [review]
patch v1.0

Updated

16 years ago
Attachment #94619 - Flags: review+
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Summary: incorrect regexp in ConvertRGBColorIntoHEXColor() → [PATCH] incorrect regexp in ConvertRGBColorIntoHEXColor()
Whiteboard: fix in hand, needs sr=
(Assignee)

Comment 2

16 years ago
Created attachment 94623 [details] [diff] [review]
patch v1.1

better patch, thanks Neil

Updated

16 years ago
Attachment #94623 - Flags: review+

Updated

16 years ago
Keywords: approval, patch
Comment on attachment 94623 [details] [diff] [review]
patch v1.1

sr=bzbarsky if you add \s* before the commas too.
(Assignee)

Comment 4

16 years ago
checked in (trunk)
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Whiteboard: fix in hand, needs sr=
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.