1618960 - Redundant function MsgGetHdrsFromKeys() in nsMsgUtils

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Ben Campbell]

mailnews/base/util/nsMsgUtils.cpp contains both MsgGetHdrsFromKeys() and MsgGetHeadersFromKeys() which do the same thing.
MsgGetHeadersFromKeys() is the more modern one - it takes in nsTArray<nsMsgKey> instead of the old-style pointer+length param pair used by MsgGetHdrsFromKeys().

So MsgGetHdrsFromKeys() is for the chop. It's only used in a couple of places.
I've already got a patch - I'll post it as soon as I've got a try run.

Note also: MsgGetHeadersFromKeys() is due for a change, as part of the nsIArray removal (Bug 1583030).

Comment 1

[Ben Campbell]

Attachment: 1618960-remove-MsgGetHdrsFromKeys-1.patch

Try build looks good:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=bc586f60d961ae233b36aa90581460fcc62225f0
(there are search test breakages, but unrelated to this and being addressed elsewhere)

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9130899 [details] [diff] [review]
1618960-remove-MsgGetHdrsFromKeys-1.patch

Review of attachment 9130899 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf815c43a45b
Remove redundant MsgGetHdrsFromKeys() in nsMsgUtils. r=mkmelin