Closed Bug 1619109 Opened 11 months ago Closed 11 months ago

Use forced state of toggle() method in highlighters

Categories

(DevTools :: Inspector, enhancement)

Product:
DevTools
Component:
Inspector
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: sebo, Assigned: sebo)

References

Details

Attachments

(1 file)

Bug 1619109 - Used toggle() method for toggling CSS class in Measuring Tool. r=pbro
47 bytes, text/x-phabricator-request
Details | Review

Bug 1597046 introduced a second parameter to the toggle() method, which allows to force a CSS class to be added or removed.

This feature is at least meant to be used for the Measuring Tool (see bug 1152321), though it might also be used for other highlighters.

Sebastian

See Also: → 1597046, 1152321
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED

I didn't see any similar use of classList.add() and classList.remove() in the other highlighters where a forced classList.toggle() is applicable, so I just changed it in the Measuring Tool.

Sebastian

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30f443ed59d1
Used toggle() method for toggling CSS class in Measuring Tool. r=pbro

https://hg.mozilla.org/mozilla-central/rev/30f443ed59d1

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.