1619122 - Firefox don't listed in context menu "open with..." with file type .jpg extension

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Boby]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

With version 73.0.1 Firefox. Right click on file with .jpg extension

Actual results:

Since installation of version 73.01, Firefox is no longer offered in the list of the context menu "Open with ..." when you right-click on a .jpg file

Expected results:

Firefox should have been offered in the list of applications in the context menu "Open with ..."

Comment 1

[Daniel Bodea [:danibodea]]

Please explain how you reach the situation to right-click a jpg file in firefox or give us a link or write a test case.
Thank you for your contribution!

Comment 2

[Boby]

Hello, I thought, however, that I had been clear: for a file with extension .jpg, click the right mouse button to have the context menu, then click on "Open with ...", and there since version 73.0.1, FireFox doesn’t no longer appears in the list where as in version 72.0.2, FireFox appeared well.

Comment 3

[Boby]

Hello, I thought, however, that I had been clear: for a file with extension .jpg, click the right mouse button to have the context menu, then click on "Open with ...", and there since version 73.0.1, FireFox doesn’t no longer appears in the list where as in version 72.0.2, FireFox appeared well.

Comment 4

[Daniel Bodea [:danibodea]]

I believe this might not be a valid issue because the browser is not a primary application for JPG files. Only JPG specific apps should be listed there. However, you CAN open a JPG file with Firefox if you go "Open With...", then "Choose another app" and then c;lick on "More apps" and if you can't find the browser there, you can "Look for another app on this PC" to locate the executable file of the Firefox browser and select it to open the picture with it.

I would like to have some developer from File Handling have an opinion on this.

Thank you for your contribution!

Comment 5

[Boby]

I'm sorry but that possibility existed before and the new FireFox 73.0.1 version removed it. Please put it back. Thank You

Comment 6

[Daniel Bodea [:danibodea]]

Can you please have an opinion on this bug? Thanks.

Comment 7

[:Gijs (he/him)]

Molly, I think this is a side effect of the fix for a security bug. Does that look right to you, and if so, can we add jpg and other image types we support to the "supported file types" list in the registry, or are there other negative consequences for doing so?

Comment 8

[Molly Howell (she/her) (no longer active)]

It looks like you're right about that being the regressing change. We've never registered ourselves as a handler for image files, meaning we weren't doing anything to get ourselves into that open with list, but before it was possible for a user to add us there by manually selecting to open an image file in Firefox. We accidentally disabled that capability for those file types. I don't see any harm in adding the image types as supported, so I'll take this bug and get that patch done.

Gijs, do you happen to know where I can find a list of all the image file types we're expected to support opening? I can look, but maybe you'll have a better idea where to look.

Comment 9

[:Gijs (he/him)]

(In reply to Molly Howell (she/her) [:mhowell] from comment #8)

Gijs, do you happen to know where I can find a list of all the image file types we're expected to support opening? I can look, but maybe you'll have a better idea where to look.

I think this is the list we want: https://searchfox.org/mozilla-central/rev/7d0c94a0e9a9fe1f83553f49b10128567d21709d/layout/build/components.conf#16 (plus the webm ones a bit further down) - those are mimetypes, not file extensions, but I assume we can deduce those...

:aosmond, can you confirm if that's the right thing to be looking at?

Comment 10

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1619122 - List more supported file types in our Applications registry key. r=agashlin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76afd03a4c03
List more supported file types in our Applications registry key. r=agashlin

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/76afd03a4c03

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Seems like a pretty low-risk uplift if you want to nominate this for Beta approval.

Comment 14

[Molly Howell (she/her) (no longer active)]

Comment on attachment 9135462 [details]
Bug 1619122 - List more supported file types in our Applications registry key. r=agashlin

Beta/Release Uplift Approval Request

• User impact if declined: Windows users are unable to register Firefox as a possible "Open With" option for local file types that we support opening but do not register a specific handler for, which more or less means anything that isn't an HTML variant.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): All this patch does is tell Windows about some more of the file types that Firefox can open, so it doesn't leave us off Open With lists for them.
• String changes made/needed:

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9135462 [details]
Bug 1619122 - List more supported file types in our Applications registry key. r=agashlin

Approved for 76.0b2.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b92bac4d814a7571058da69a2902947964e4b64

Comment 17

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 75.0 on Windows 10 64bit.

I can confirm that this issue is verified fixed using Firefox 76.0b2 (BuildId:20200407205853) and Firefox 77.0a1 (BuildId:20200408214238) on Windows 10 64bit.

• Checked that the full list with the changes from https://phabricator.services.mozilla.com/D68062 is successfully added inside HKEY_CLASSES_ROOT\Applications\firefox.exe\SupportedTypes
• Firefox is added (for the supported file types) inside the "Open With" context menu and the files can be open successfully with Firefox.

With a note that, for some file extensions that were not previously accessed with Firefox, Firefox will not be displayed as an option inside the "Open With" submenu. In order for Fx to be displayed in that submenu you need to open that particular file with Firefox at least once (Open With > Choose another app > Firefox).