1619139 - Search button is not toggled anymore

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Sebastian Zartner [:sebo]]

What were you doing?

1. Open the Network Monitor on this page.
2. Click the Search button to open the left sidebar

What happened?

The sidebar opens as expected but the Search button is not highlighted anymore, i.e. it doesn't reflect the open state of the sidebar anymore.

What should have happened?

The button should be pressed as long as the left side bar is open, i.e. the background should be highlighted and the icon should be blue.

Anything else we should know?

I assume this regression is caused by bug 1581790. (mozregression says it happend in https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=10059adf004590aca187aab75d0e46a6cfde1e44&tochange=99066bbd1b3a288471f2bf7f59f1c99da42610a1).

Sebastian

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report Sebastian. I can reproduce the issue on my machine.

Pranav, can you please look at this, you were working on bug 1581790

Honza

Comment 2

[Pranav pandey]

Attachment: Bug 1619139 - fixed reach button toggle issue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8fc7d8b7245
fixed reach button toggle issue. r=Honza

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a8fc7d8b7245

Comment 5

[Sebastian Zartner [:sebo]]

Thank you for the fast fix!
Verified that it's working as expected with 75.0a1 (2020-03-02) on Windows 10.

Sebastian