1619165 - clang-format Refresh the tree once clang-format 10 is live

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

https://reviews.llvm.org/D69573 will ship with clang-10 and introduces some changes in our code base.

-  operator Rooted<T>&() { return *savedRoot; }
+  operator Rooted<T> &() { return *savedRoot; }

or

-    operator const nsIFrame*() const { return mFrame; }
+    operator const nsIFrame *() const { return mFrame; }

Nothing too fancy

Comment 1

[Mike Hommey [:glandium]]

This change doesn't make sense to me, considering we're preferring the form nsIFrame* frame to nsIFrame *frame.

Comment 2

[Mike Hommey [:glandium]]

The LLVM patch even looks like it respects PointerAlignment, and that it shouldn't make a difference for PointerAlignment = Left (which is what we have).

Comment 3

[Sylvestre Ledru [:Sylvestre]]

I forgot to give links to the upstream changes.
https://reviews.llvm.org/D69573
and a regression fix:

https://reviews.llvm.org/D72911
(not in 10.0rc2)

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1619165 - Reformat recent changes to the Google coding style r=Ehsan,andi

Comment 5

[Sylvestre Ledru [:Sylvestre]]

I reported upstream two regressions:
https://bugs.llvm.org/show_bug.cgi?id=45357
https://bugs.llvm.org/show_bug.cgi?id=45358

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad8bd78754b2
Reformat recent changes to the Google coding style r=andi

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ad8bd78754b2

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1619165 - Reformat recent changes to the Google coding style r=andi

ignore-this-changeset

Comment 9

[Phabricator Automation]

Comment on attachment 9144842 [details]
Bug 1619165 - Reformat recent changes to the Google coding style r=andi

Revision D73347 was moved to bug 1519636. Setting attachment 9144842 [details] to obsolete.