1619296 - Make the TargetCommand populate its own redux store

Status: RESOLVED FIXED

(DevTools :: Console, task, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

At the moment, we rely on the existence of a toolbox in order to subscribe to its store, and get the different frames in the context switch list.

In order for the Browser Console to benefit from the same feature, we'd need to do things differently (as we don't have a toolbox).

Comment 1

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 2

[Chris Peterson [:cpeterson]]

dt-fission-m2-reserve bugs do not need to block Fission Nightly (M6). For now, let's track them for Fission riding the trains to Beta (M7) so we revisit these bugs before we ship Fission.

Comment 3

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

removing from Fission as it will be part of the context selector project

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1619296 - [devtools] Use private fields in BrowserConsole. r=ochameau.

Depends on D150087

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1619296 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.

Depends on D150088

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1619296 - [devtools] Make the TargetCommand populate its own redux store.

This allows to pull out target management code out from toolbox back to TargetCommand.
And then allows to more easily share this store in the context of the browser console,
where there is no toolbox.

This is also an interesting example on how commands may populate redux store directly
so that we avoid having each panel translate commands's event into actions.

An alternative here, would be to introduce some generic layer between commands and redux.
Which would be the glue between a command and populating a store.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/040ad599c5ee
[devtools] Make the TargetCommand populate its own redux store. r=nchevobbe

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

(didn't see Alex's patch was tied to this bug, so let's rename it and have another one for the context selector in the browser console)

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/040ad599c5ee

Comment 11

[Phabricator Automation]

Comment on attachment 9282522 [details]
Bug 1619296 - [devtools] Use private fields in BrowserConsole. r=ochameau.

Revision D150088 was moved to bug 1780156. Setting attachment 9282522 [details] to obsolete.

Comment 12

[Phabricator Automation]

Comment on attachment 9282524 [details]
Bug 1619296 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.

Revision D150090 was moved to bug 1780156. Setting attachment 9282524 [details] to obsolete.