Closed Bug 1619296 Opened 3 years ago Closed 2 months ago

Make the TargetCommand populate its own redux store

Categories

(DevTools :: Console, task, P2)

task

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: nchevobbe, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

At the moment, we rely on the existence of a toolbox in order to subscribe to its store, and get the different frames in the context switch list.

In order for the Browser Console to benefit from the same feature, we'd need to do things differently (as we don't have a toolbox).

Whiteboard: dt-fission-m2-mvp

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6
Whiteboard: dt-fission-m2-mvp → dt-fission-m2-reserve

dt-fission-m2-reserve bugs do not need to block Fission Nightly (M6). For now, let's track them for Fission riding the trains to Beta (M7) so we revisit these bugs before we ship Fission.

Fission Milestone: M6 → M7

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Fission Milestone: M7 → MVP

removing from Fission as it will be part of the context selector project

Whiteboard: dt-fission-m2-reserve
Fission Milestone: MVP → ---
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Attachment #9282524 - Attachment description: Bug 1619296 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau. → WIP: Bug 1619296 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.
Attachment #9282524 - Attachment description: WIP: Bug 1619296 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau. → Bug 1619296 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.

This allows to pull out target management code out from toolbox back to TargetCommand.
And then allows to more easily share this store in the context of the browser console,
where there is no toolbox.

This is also an interesting example on how commands may populate redux store directly
so that we avoid having each panel translate commands's event into actions.

An alternative here, would be to introduce some generic layer between commands and redux.
Which would be the glue between a command and populating a store.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/040ad599c5ee
[devtools] Make the TargetCommand populate its own redux store. r=nchevobbe

(didn't see Alex's patch was tied to this bug, so let's rename it and have another one for the context selector in the browser console)

Summary: Add context switch button to Browser Console → Make the TargetCommand populate its own redux store
Assignee: nchevobbe → poirot.alex
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

Comment on attachment 9282522 [details]
Bug 1619296 - [devtools] Use private fields in BrowserConsole. r=ochameau.

Revision D150088 was moved to bug 1780156. Setting attachment 9282522 [details] to obsolete.

Attachment #9282522 - Attachment is obsolete: true

Comment on attachment 9282524 [details]
Bug 1619296 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.

Revision D150090 was moved to bug 1780156. Setting attachment 9282524 [details] to obsolete.

Attachment #9282524 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.