Make the TargetCommand populate its own redux store
Categories
(DevTools :: Console, task, P2)
Tracking
(firefox104 fixed)
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
At the moment, we rely on the existence of a toolbox in order to subscribe to its store, and get the different frames in the context switch list.
In order for the Browser Console to benefit from the same feature, we'd need to do things differently (as we don't have a toolbox).
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6) milestone
|
||
Updated•4 years ago
|
|
|
||
Comment 2•4 years ago
|
||
dt-fission-m2-reserve bugs do not need to block Fission Nightly (M6). For now, let's track them for Fission riding the trains to Beta (M7) so we revisit these bugs before we ship Fission.
|
||
Comment 3•4 years ago
|
||
Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.
|
|
Reporter | |
Comment 4•3 years ago
|
||
removing from Fission as it will be part of the context selector project
|
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 5•2 years ago
|
||
Depends on D150087
|
||
Updated•2 years ago
|
|
|
Reporter | |
Comment 6•2 years ago
|
||
Depends on D150088
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 7•2 years ago
|
||
This allows to pull out target management code out from toolbox back to TargetCommand.
And then allows to more easily share this store in the context of the browser console,
where there is no toolbox.
This is also an interesting example on how commands may populate redux store directly
so that we avoid having each panel translate commands's event into actions.
An alternative here, would be to introduce some generic layer between commands and redux.
Which would be the glue between a command and populating a store.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/040ad599c5ee [devtools] Make the TargetCommand populate its own redux store. r=nchevobbe
|
|
Reporter | |
Comment 9•2 years ago
|
||
(didn't see Alex's patch was tied to this bug, so let's rename it and have another one for the context selector in the browser console)
|
|
Reporter | |
Updated•2 years ago
|
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
|
|
||
Comment 11•2 years ago
|
||
Comment on attachment 9282522 [details]
Bug 1619296 - [devtools] Use private fields in BrowserConsole. r=ochameau.
Revision D150088 was moved to bug 1780156. Setting attachment 9282522 [details] to obsolete.
|
|
||
Comment 12•2 years ago
|
||
Comment on attachment 9282524 [details]
Bug 1619296 - [devtools] Add EvaluationContextSelector to BrowserConsole. r=ochameau.
Revision D150090 was moved to bug 1780156. Setting attachment 9282524 [details] to obsolete.
Description
•