1619318 - The "X" button inside the cards is not focused while navigation with Tab key

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P2)

Description

[Ciprian Georgiu, Desktop QA]

Affected versions

• latest Nightly 75.0a1

Affected platforms

• Windows 10 x64
• macOS 10.15
• Ubuntu 18.04 x64

Steps to reproduce

1. Launch Firefox and navigate to "about:protections".
2. Navigate using the Tab key to the “X” button from the “Take your passwords everywhere” or “Block ad trackers across more devices” cards (to enable this last card you need to change the browser.contentblocking.report.show_mobile_app to true)

Expected result

• The “X” button is focused.

Actual result

• The “X” button cannot be focused; when reaching the iOS link from the card, it goes to the next button/link, skipping the close button.

Regression range

• This doesn’t seem to be a regression, I was able to reproduce this on an older Nightly build as well, e.g 75.0a1 (2020-02-25); one of the first builds with these banners implemented.

Comment 1

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/rev/2fd8ffcf087bc59a8e5c962965bbb7bf230bcd28/browser/components/protections/content/protections.html#226 and https://searchfox.org/mozilla-central/rev/2fd8ffcf087bc59a8e5c962965bbb7bf230bcd28/browser/components/protections/content/protections.html#119 should probably be a button, not a span. It should also get a localized string as the aria-label, or if these are trying to point to an element for a label, should use aria-labelledby.

Erica, is this something you could work on or perhaps mentor as a good first bug?

Comment 2

[Jayati Shrivastava]

Hi! May I submit a patch for this?

Comment 3

[Jayati Shrivastava]

Attachment: Bug 1619318- Ensures "X" button is focused when navigating using Tab key. r=Gijs

Depends on D66217

Comment 4

[Jayati Shrivastava]

Attachment: After the fix

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:ewright, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

:gaurijove, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12948ea92335
Ensures "X" button is focused when navigating using Tab key. r=Gijs,fluent-reviewers

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/12948ea92335

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gaurijove, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Johann Hofmann [:johannh]]

Erica should make the call on that :)

Comment 12

[Erica Wright [:ewright]]

Yes, let's uplift this. The mobile promotion has been pushed back, so we don't need to worry about that one for 75, however this patch also addresses the same issue for the Lockwise card, and that will be visible in 75.
On second thought, I realize there is a string in this, so it would be unfair to l10n to uplift. I'll let this ride the trains.

Comment 13

[Maria Berlinger [:mberlinger], Services QA]

I've managed to reproduce this issue on an affected Firefox nightly from 2020-03-02 on Ubuntu 18.04x64.
This issue is verified fixed on Firefox 76.0b4 using Windows 10x64, Ubuntu 18.04x64 and macOS 10.15.4.