Closed
Bug 161932
Opened 22 years ago
Closed 4 years ago
nsMsgAttachment::DeleteAttachment() could use a rewrite
Categories
(MailNews Core :: Composition, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: timeless, Unassigned)
Details
(Whiteboard: [patchlove][has draft patch])
Attachments
(1 obsolete file)
1. rev1.6 caused the function to take a random codepath each time it's run :-)
2. the function does a lot of hopefully useless checks.
i need someone who understands how ns*File::IsFile works to look over this
patch because the function has no documentation (bug 161912)
|
||
Comment 2•22 years ago
|
||
see bug 157131... i've got a very similar patch already r='d ;-)
|
||
Updated•20 years ago
|
Product: MailNews → Core
|
||
Updated•17 years ago
|
Assignee: ducarroz → nobody
QA Contact: stephend → composition
|
Assignee | |
Updated•16 years ago
|
Product: Core → MailNews Core
|
||
Comment 4•14 years ago
|
||
Comment on attachment 94639 [details] [diff] [review]
draft
(In reply to comment #3)
> shall we call this fixed?
Anyway the patch has bitrotted, though I have no idea whether the issue is already fixed.
$ patch -p1 --dry-run < ~/Desktop/p161932.diff
(Stripping trailing CRs from patch.)
patching file mailnews/compose/src/nsMsgAttachment.cpp
Hunk #1 FAILED at 175.
1 out of 1 hunk FAILED -- saving rejects to file mailnews/compose/src/nsMsgAttachment.cpp.rej
Attachment #94639 -
Attachment is obsolete: true
|
||
Comment 5•9 years ago
|
||
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.
|
||
Comment 7•4 years ago
|
||
Yep, nothing left to do here.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(mkmelin+mozilla)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•