clean up simple mac build warnings

RESOLVED FIXED

Status

SeaMonkey
Build Config
RESOLVED FIXED
16 years ago
12 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
 
(Assignee)

Comment 1

16 years ago
Created attachment 94822 [details] [diff] [review]
mostly (re)moving unused variables
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Comment on attachment 94822 [details] [diff] [review]
mostly (re)moving unused variables

+#if DEBUG

Shouldn't that be #ifdef?

Other than that, sr=me assuming that this compiles with all the various values
of the defines involved....
Attachment #94822 - Flags: superreview+
(Assignee)

Comment 3

16 years ago
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/nsprpub/pr/src/md/mac/macio.c&rev=3.34&root=/cvsroot&mark=1441,1299#1439
it looked odd to me but i was using the tried and true copy what's there approach.

Comment 4

16 years ago
Comment on attachment 94822 [details] [diff] [review]
mostly (re)moving unused variables

r=dbradley

Is it worth preserving the DragEnter variable declarations?
Attachment #94822 - Flags: review+
(Assignee)

Updated

16 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

16 years ago
i filed bug 166257 for the nspr change. i'm going to discard the freebl change
(it's not our code).
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.