Closed
Bug 161945
Opened 22 years ago
Closed 22 years ago
clean up simple mac build warnings
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
Attachments
(1 file)
|
14.21 KB,
patch
|
dbradley
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
|
||
Comment 2•22 years ago
|
||
Comment on attachment 94822 [details] [diff] [review] mostly (re)moving unused variables +#if DEBUG Shouldn't that be #ifdef? Other than that, sr=me assuming that this compiles with all the various values of the defines involved....
Attachment #94822 -
Flags: superreview+
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/nsprpub/pr/src/md/mac/macio.c&rev=3.34&root=/cvsroot&mark=1441,1299#1439 it looked odd to me but i was using the tried and true copy what's there approach.
|
||
Comment 4•22 years ago
|
||
Comment on attachment 94822 [details] [diff] [review] mostly (re)moving unused variables r=dbradley Is it worth preserving the DragEnter variable declarations?
Attachment #94822 -
Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
i filed bug 166257 for the nspr change. i'm going to discard the freebl change (it's not our code).
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•