Closed Bug 1619476 Opened 4 years ago Closed 4 years ago

RDM crashes when adding a duplicate device

Categories

(DevTools :: Responsive Design Mode, defect, P1)

defect

Tracking

(firefox75 verified)

VERIFIED FIXED
Firefox 75
Tracking Status
firefox75 --- verified

People

(Reporter: mtigley, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: fission-rdm-reserve)

Attachments

(1 file)

STR

  1. Make sure devtools.responsive.browserUI.enabled is true.
  2. Open RDM and open the device settings menu.
  3. Try adding a device that already has the same name in the Custom Devices list.

Expected
A form error will be shown saying "Device name already in use" and the new device will not be submitted.

Actual
RDM crashes (the toolbar disappears)

This suggests our name validator in https://searchfox.org/mozilla-central/source/devtools/client/responsive/components/DeviceForm.js#115 is failing. Note that this only happens for the new RDM.

Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: fission-rdm-reserve
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b24ad6866dc
Prevent submitting device form on an invalidation r=bradwerth
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Flags: qe-verify+

I’ve managed to reproduce this issue with Fx 75.0a1 (2020-03-02) on Windows 10.
The issue is verified fixed (can’t add a duplicate device) with Fx 76.0a1 (2020-03-18) and Fx 75.0b5 on Windows 10 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: