1619518 - Get rid of BlobImpl::IsSizeUnknown and BlobImpl::IsDateUnknown

Status: RESOLVED FIXED

(Core :: DOM: File, task, P3)

Description

[Andrea Marchesini [:baku]]

We have just 1 BlobImpl class with lazy GetLength() and GetLastModified(): FileBlobImpl. We should keep the complexity of those 2 methods in FileBlobImpl.

In this bug I want to fix the last-modified default value in here:
https://searchfox.org/mozilla-central/rev/91f6c02fcf4c16f78fdc4417f61f192688294066/dom/file/FileBlobImpl.cpp#40

In this CTOR we pass UINT64_MAX instead of INT64_MAX as lastModified.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1619518 - part 2 - Better File.lastModified attribute handling, r?ssengupta

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1619518 - Removed a BaseBlobImpl CTOR, r?ssengupta

Depends on D65074

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1619518 - Get rid of BlobImpl::IsSizeUnknown and BlobImpl::IsDateUnknown, r?ssengupta

Depends on D65075

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1619518 - part 1 - Remove a EmptyBlobImpl CTOR, r?ssengupta

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1619518 - part 3 - Better File.length attribute handling, r?ssengupta

Depends on D65074

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1619518 - part 4 - FileBlobImpl inherits BlobImpl directly, r?ssengupta

Depends on D65165

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa25ea873fa9
part 1 - Remove a EmptyBlobImpl CTOR, r=ssengupta
https://hg.mozilla.org/integration/autoland/rev/403e9b8e2040
part 2 - Better File.lastModified attribute handling, r=ssengupta,ttung,dom-workers-and-storage-reviewers,smaug
https://hg.mozilla.org/integration/autoland/rev/eb4b8aa164e8
part 3 - Better File.length attribute handling, r=ssengupta,smaug
https://hg.mozilla.org/integration/autoland/rev/f848fd145194
part 4 - FileBlobImpl inherits BlobImpl directly, r=ssengupta,smaug

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (Bug 1619518) for mochitest failures at test_temporaryFileBlob.html.
https://hg.mozilla.org/integration/autoland/rev/4e5681a0da79535a679eeaad48bd23ce46d33b0b

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=f848fd145194dea1bee4f54660ad6b6aa8c4b6f9&selectedJob=291713895

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291713895&repo=autoland&lineNumber=4854

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56be1c62b9e2
part 1 - Remove a EmptyBlobImpl CTOR, r=ssengupta
https://hg.mozilla.org/integration/autoland/rev/8ee9f73f0551
part 2 - Better File.lastModified attribute handling, r=ssengupta,ttung,dom-workers-and-storage-reviewers,smaug
https://hg.mozilla.org/integration/autoland/rev/6974a7016aaf
part 3 - Better File.length attribute handling, r=ssengupta,smaug
https://hg.mozilla.org/integration/autoland/rev/e6793b0b1b3f
part 4 - FileBlobImpl inherits BlobImpl directly, r=ssengupta,smaug

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/56be1c62b9e2
https://hg.mozilla.org/mozilla-central/rev/8ee9f73f0551
https://hg.mozilla.org/mozilla-central/rev/6974a7016aaf
https://hg.mozilla.org/mozilla-central/rev/e6793b0b1b3f