nsIPermissionManager::RemoveAll doesn't update perm file

RESOLVED FIXED in mozilla1.2beta

Status

()

P2
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: cls, Assigned: morse)

Tracking

Trunk
mozilla1.2beta
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
I was attempting to add a "Clear blocked cookie sites" button to the preferences
pane of chimera for bug 160123 when I ran across this.  Whenever
nsIPermissionManager::RemoveAll is called, the results are never flushed to the
disk.  Looking at nsPermissionManager.cpp, ::RemoveAll just calls
PERMISSION_RemoveAll which just clears the in-memory permission list.  Based
upon nsCookieManager.cpp, a _Write function should be getting called.
PERMISSION_Save is never called.  However, calling PERMISSION_Save wouldn't help
either as it exits early if the permission list is null.  So how do you write an
empty permissions file?
Created attachment 94656 [details] [diff] [review]
Remove the perm file instead of saving an empty one
(Assignee)

Comment 2

16 years ago
Comment on attachment 94656 [details] [diff] [review]
Remove the perm file instead of saving an empty one

r=morse
Attachment #94656 - Flags: review+
(Assignee)

Comment 3

16 years ago
cc'ing alecf for sr
Status: NEW → ASSIGNED
Keywords: nsbeta1
Priority: -- → P2
Target Milestone: --- → mozilla1.2beta

Comment 4

16 years ago
Comment on attachment 94656 [details] [diff] [review]
Remove the perm file instead of saving an empty one

sr=alecf
Attachment #94656 - Flags: superreview+
(Assignee)

Comment 5

16 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.