161952 - nsIPermissionManager::RemoveAll doesn't update perm file

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect, P2)

Description

[cls]

I was attempting to add a "Clear blocked cookie sites" button to the preferences
pane of chimera for bug 160123 when I ran across this.  Whenever
nsIPermissionManager::RemoveAll is called, the results are never flushed to the
disk.  Looking at nsPermissionManager.cpp, ::RemoveAll just calls
PERMISSION_RemoveAll which just clears the in-memory permission list.  Based
upon nsCookieManager.cpp, a _Write function should be getting called.
PERMISSION_Save is never called.  However, calling PERMISSION_Save wouldn't help
either as it exits early if the permission list is null.  So how do you write an
empty permissions file?

Comment 1

[hacker formerly known as [e-mail]]

Attachment: Remove the perm file instead of saving an empty one

Comment 2

[Stephen P. Morse]

Comment on attachment 94656 [details] [diff] [review]
Remove the perm file instead of saving an empty one

r=morse

Comment 3

[Stephen P. Morse]

cc'ing alecf for sr

Comment 4

[Alec Flett]

Comment on attachment 94656 [details] [diff] [review]
Remove the perm file instead of saving an empty one

sr=alecf

Comment 5

[Stephen P. Morse]

Fix checked in.