Closed
Bug 161952
Opened 23 years ago
Closed 22 years ago
nsIPermissionManager::RemoveAll doesn't update perm file
Categories
(Core :: Networking: Cookies, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.2beta
People
(Reporter: cls, Assigned: morse)
Details
Attachments
(1 file)
588 bytes,
patch
|
morse
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
I was attempting to add a "Clear blocked cookie sites" button to the preferences
pane of chimera for bug 160123 when I ran across this. Whenever
nsIPermissionManager::RemoveAll is called, the results are never flushed to the
disk. Looking at nsPermissionManager.cpp, ::RemoveAll just calls
PERMISSION_RemoveAll which just clears the in-memory permission list. Based
upon nsCookieManager.cpp, a _Write function should be getting called.
PERMISSION_Save is never called. However, calling PERMISSION_Save wouldn't help
either as it exits early if the permission list is null. So how do you write an
empty permissions file?
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•22 years ago
|
||
Comment on attachment 94656 [details] [diff] [review]
Remove the perm file instead of saving an empty one
r=morse
Attachment #94656 -
Flags: review+
Assignee | ||
Comment 3•22 years ago
|
||
cc'ing alecf for sr
Comment 4•22 years ago
|
||
Comment on attachment 94656 [details] [diff] [review]
Remove the perm file instead of saving an empty one
sr=alecf
Attachment #94656 -
Flags: superreview+
Assignee | ||
Comment 5•22 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•