Update expectation states of Puppeteer tests to pass on MacOS
Categories
(Remote Protocol :: Agent, task, P1)
Tracking
(firefox75 fixed)
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [puppeteer-beta-mvp])
Attachments
(1 file)
A couple of Puppeteer unit tests have been updated not that long ago, but as it turned out I see a lot of hangs and crashes of the harness because of those. To be able to continue working locally I will have to disable some of those again. Mainly it affects tests from launcher.spec.js.
I also tested others which are marked as disabled if they can be enabled. That is the case and locally I got the following results:
Ran 638 (ok - 262, failed - 242, skipped - 134) of 638 test(s)
That's pretty promising in having 31 more tests passing!
Here a try build for those changes:
https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=610c1141b3a9a3ecc9ea25ba99ff34edecdf3e94
In the future we should make sure to keep tests passing on Linux (CI) and MacOS (has to be tested locally).
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Marking as leave open so I can follow-up with a PR on the Puppeteer repo.
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6488af73b52 [remote] Update expectation states of Puppeteer unit tests to pass on MacOS. r=remote-protocol-reviewers,maja_zf
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 5•4 years ago
|
||
PR for Puppeteer is up at:
https://github.com/puppeteer/puppeteer/pull/5473
There is no need to keep this bug open anytime longer.
|
|
||
Updated•4 years ago
|
Description
•