1619549 - Factor out code of maintained range in `nsFrameSelection`

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Mirko Brodesser (:mbrodesser-Igalia)]

Helps understanding and simplifying nsFrameSelection.

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1619549: part 1) Group `mMaintainRange` and `mMaintainedAmount` in `MaintainedRange`. r=jfkthame

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1619549: part 2) Add assertion to `nsFrameSelection::HandleClick`. r=jfkthame

Helps reasoning about it.

Depends on D65106

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1619549: part 3) Use `RefPtr` in `nsFrameSelection::HandleClick`. r=jfkthame

Simplifies following simplifications.

Depends on D65117

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1619549: part 4) Move `nsFrameSelection::AdjustForMaintainedSelection` to `MaintainedRange`. r=jfkthame

Depends on D65118

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1619549: part 5) Move core of `nsFrameSelection::MaintainSelection` to `MaintainedRange`. r=jfkthame

Depends on D65119

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1619549: part 6) Factor out code from `nsFrameSelection::HandleDrag` to `MaintainedRange::AdjustContentOffsets`. r=jfkthame

Depends on D65120

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95670f2e4bea
part 1) Group `mMaintainRange` and `mMaintainedAmount` in `MaintainedRange`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/03a15ae01488
part 2) Add assertion to `nsFrameSelection::HandleClick`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/000a4bc2ce3c
part 3) Use `RefPtr` in `nsFrameSelection::HandleClick`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/9cc3314c3295
part 4) Move `nsFrameSelection::AdjustForMaintainedSelection` to `MaintainedRange`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/7432aa9dba41
part 5) Move core of `nsFrameSelection::MaintainSelection` to `MaintainedRange`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/7717e7ede13f
part 6) Factor out code from `nsFrameSelection::HandleDrag` to `MaintainedRange::AdjustContentOffsets`. r=jfkthame

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/95670f2e4bea
https://hg.mozilla.org/mozilla-central/rev/03a15ae01488
https://hg.mozilla.org/mozilla-central/rev/000a4bc2ce3c
https://hg.mozilla.org/mozilla-central/rev/9cc3314c3295
https://hg.mozilla.org/mozilla-central/rev/7432aa9dba41
https://hg.mozilla.org/mozilla-central/rev/7717e7ede13f