Closed Bug 1619563 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22060 - [css-grid] Fix grid placement with '<integer> && <custom-ident>'

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22060 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22060
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-grid] Fix grid placement with '<integer> && <custom-ident>'

The logic for placing a grid item with both an integer and an identifier
in a placement property was interacting wrong with auto repeat() tracks.

This patch uses the same proper logic that was already implemented in
OrderedNamedLinesCollectorInGridLayout::CollectLineNamesForIndex

BUG=966090

TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-004.html

Change-Id: I042ce1fd77a79959240d272d96eac21f06e014ac
Reviewed-on: https://chromium-review.googlesource.com/2082917
WPT-Export-Revision: 47b0883aa028df9c1dc0ba3fd2dd13f34f3ed021

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/422bf06c36bd
[wpt PR 22060] - [css-grid] Fix grid placement with '<integer> && <custom-ident>', a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.