1619603 - Ship Geckoview at the ship_rc phase

Status: RESOLVED WONTFIX

(Release Engineering :: Release Automation: Uploading, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

In bug 1612540, we decided to ship Geckoview at the push phase. It's great for every case, but the RC one. We also need to publish a new geckoview at the push_rc phase.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Silly me! push_rc doesn't exist, ship_rc does.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1619603 - Ship Geckoview at the ship_rc phase r=mtabara

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c61cb2e60c2c
Ship Geckoview at the ship_rc phase r=mtabara

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9130802 [details]
Bug 1619603 - Ship Geckoview at the ship_rc phase r=mtabara

Beta/Release Uplift Approval Request

• User impact if declined: Mobile developers won't be able to use geckoview until Firefox officially ships to end-users.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No impact on the final product. It just ships geckoview on maven.mozilla.org more often.
• String changes made/needed: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9130802 [details]
Bug 1619603 - Ship Geckoview at the ship_rc phase r=mtabara

I discussed this with Johan and it doesn't seem like there's much value in taking this on Release for 74 since the logic for dot releases isn't changing and it's very unlikely there will be another RC build at this point.

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c61cb2e60c2c

Comment 7

[Johan Lorenzo [:jlorenzo]]

I realized there's a bug in the first patch: Geckoview is shipped in both the ship_rc phase[1] and the push one[2] of the same release. I need to remove them from the latter.

[1] https://firefox-ci-tc.services.mozilla.com/tasks/groups/LdaJbyQJRQKh7gizKCbS6A
[2] https://firefox-ci-tc.services.mozilla.com/tasks/groups/Zjf8_jfqSZKbN62TdX8Y_A

Comment 8

[Johan Lorenzo [:jlorenzo]]

Unassigning myself. I think it's a valid bug, but I'll don't believe I'll have enough time to handle it.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

We ship during the promote phase now and are quite happy with that.