1619630 - Several actors have a useless "dispatcher" constructor argument

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1619170 +++

All they do with it is pass it to super(), but JSWindowActorChild does not take any constructor arguments.

Comment 1

[:Gijs (he/him)]

(In reply to Neil Deakin from bug 1619170 comment #2)

There are several other actors like this as well:

https://searchfox.org/mozilla-central/search?q=super(dispatcher)&case=false&regexp=false&path=

	browser/actors/AboutReaderChild.jsm
31	super(dispatcher);
	browser/actors/OfflineAppsChild.jsm
16	super(dispatcher);
	toolkit/actors/DateTimePickerChild.jsm
24	super(dispatcher);
	toolkit/actors/PictureInPictureChild.jsm
67	super(dispatcher);
	toolkit/actors/UAWidgetsChild.jsm

Not all of these are JSWindowActor-based - notably AboutReader and OfflineApps are not. But the other 3 look like they should have this removed.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1619630 - remove useless 'dispatcher' argument to various JSWindowActorChild constructors, r?NeilDeakin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aeddcf9020e
remove useless 'dispatcher' argument to various JSWindowActorChild constructors, r=NeilDeakin

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0aeddcf9020e