Open Bug 1619645 Opened 9 months ago Updated 6 months ago

Improve wording for Magnitude of Difference aria-label

Categories

(Tree Management :: Perfherder, enhancement, P3)

x86_64
Linux
enhancement

Tracking

(Not tracked)

People

(Reporter: yonashiro.mellina, Assigned: tin.la)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

In Perfherder's Compare View, the column "Magnitude of difference" could have some improvements in terms of wording for screen reader users.

Steps to reproduce

  • This link could be used as an example, but might not be available in the future, as the data might be deleted.
  • There is a column which is Magnitude of difference. The target of this bug is its content cells.
  • The content is available only for screen-reader users, so you should check the aria-label attribute in DevTools Inspector.

The line of code to be changed is https://github.com/mozilla/treeherder/blob/master/ui/perfherder/ProgressBar.jsx#L12

It should say "Lower is better. Metric: ${number} % regressed", where number is a 2-digit decimal number.

For example, right now, the first column says:

"Magnitude of difference based on lower is better. Metric: 95.40372121801391 % regressed"

This improvement would change it to:

"Lower is better. Metric: 95.40% regressed".

Keywords: good-first-bug

Hi, I'd love to work on this. Can you please assign this to me if it's available? Thanks!

Hi,
I would like to work on this.

Priority: -- → P3

Can I work on this?

(In reply to albaalahwaqar from comment #1)

Hi, I'd love to work on this. Can you please assign this to me if it's available? Thanks!

Are you still interested in picking this up?

Flags: needinfo?(albaalahwaqar)

Hi Kimberly I'll take this one.

Assignee: nobody → tin.la
Flags: needinfo?(albaalahwaqar)

PR submitted.

You need to log in before you can comment on or make changes to this bug.