1619645 - Improve wording for Magnitude of Difference aria-label

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P3)

Description

[Mellina Yonashiro]

In Perfherder's Compare View, the column "Magnitude of difference" could have some improvements in terms of wording for screen reader users.

Steps to reproduce

• This link could be used as an example, but might not be available in the future, as the data might be deleted.
• There is a column which is Magnitude of difference. The target of this bug is its content cells.
• The content is available only for screen-reader users, so you should check the aria-label attribute in DevTools Inspector.

---

The line of code to be changed is https://github.com/mozilla/treeherder/blob/master/ui/perfherder/ProgressBar.jsx#L12

It should say "Lower is better. Metric: ${number} % regressed", where number is a 2-digit decimal number.

For example, right now, the first column says:

"Magnitude of difference based on lower is better. Metric: 95.40372121801391 % regressed"

This improvement would change it to:

"Lower is better. Metric: 95.40% regressed".

Comment 1

[albaalahwaqar]

Hi, I'd love to work on this. Can you please assign this to me if it's available? Thanks!

Comment 2

[Soniya Nayak]

Hi,
I would like to work on this.

Comment 3

[Shubham Kumar [:imskr]]

Can I work on this?

Comment 4

[Kimberly Sereduck :kimberlythegeek]

(In reply to albaalahwaqar from comment #1)

Hi, I'd love to work on this. Can you please assign this to me if it's available? Thanks!

Are you still interested in picking this up?

Comment 5

[Tin La]

Hi Kimberly I'll take this one.

Comment 6

[Tin La]

PR submitted.

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6470