Consider not setting the shortName of an engine to the telemetry ID
Categories
(Firefox :: Search, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
In bug 1605164, I am adding a new field on nsISearchEngine for the telemetry ID of an engine.
Currently when we're loading engines, if the configuration has a telemetry ID specified, then we override the short name with that telemetry ID.
We should no longer need to do this, but we should also investigate it to be sure. We may be able to look towards removing short name altogether. Some things to consider:
- Is anything still relying on short name (also via
identifier) to be reported to telemetry? - Does short name affect anything that is cached?
- Do we still need to use short name for various things, e.g. opensearch engines?
|
Assignee | |
Comment 1•4 years ago
|
||
As part of the post-modern work, we should consider this and decide if it is something we want to do or not.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Having reviewed our existing code, I think we can remove the short name - it isn't actually used, except to generate the load path for the engine. Both the load path generation function call points have the details locally, so we don't need to store the short name for those.
I'd still like to remove Search Service's reliance on the full name at some stage, but I think that the short name is unlikely to be the best way to do that.
|
|
Assignee | |
Comment 3•4 years ago
|
||
The _shortName variable is basically redundant, and we can transfer the remaining 'identifier' handling across to the telemetry Id as they were virtually the same.
Depends on D88622
|
|
Assignee | |
Updated•4 years ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb3eb0d759b6 Drop the separate recording of _shortName in the search service, use the telemetry Id instead. r=daleharvey
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•