Closed Bug 1619694 Opened 11 months ago Closed 8 months ago

Send Impression ping when respective screen is visible for multistage aboutwelcome.jsx

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 78
Iteration:
78.2 - May 18 - May 31
Tracking Status
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- verified

People

(Reporter: andreio, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assignee: nobody → pdahiya
Type: defect → enhancement
Iteration: --- → 76.1 - Mar 9 - Mar 22
Priority: -- → P1

Simplified about:welcome yet doesn't have need to handle sending impression If content changes while the page is hidden (i.e. preloaded or on a hidden tab) as about:welcome is first page shown to a new profile.

Having said that we do have desire to collect telemetry around which onboarding card is shown to the user. As of now we are sending event telemetry only on click of card.

See https://mozilla.slack.com/archives/G90HG2UQH/p1583974728270000?thread_ts=1583949500.261500&cid=G90HG2UQH

ImpressionsWrapper component in asrouter send the event if the page becomes visible again, Changing the scope of this bug to implement a generic impression wrapper that sends impression when a component on a page is first shown to user e.g. extended triplets onboarding card on default about:welcome in 75 .

We can split onvisibility change and send impression handling inside impression wrapper, essentially writing a visibility wrapper. sendImpression can be passed to VisibilityWrapper from outside e.g. <VisibilityWrapper onVisible={sendImpression} />

We should pick this implementation after the UI requirements for 76 are finalized.

Assignee: pdahiya → nobody
Iteration: 76.1 - Mar 9 - Mar 22 → 76.2 - Mar 23 - Apr 5
Priority: P1 → P2
Iteration: 76.2 - Mar 23 - Apr 5 → 77.1 - Apr 6 - Apr 19
Iteration: 77.1 - Apr 6 - Apr 19 → 77.2 - Apr 20 - May 3
Iteration: 77.2 - Apr 20 - May 3 → 78.1 - May 4 - May 17

With multistage about:welcome UI we need sending impression ping when a screen is visible. Removing P2 flag to triage and pick this work for 78

Iteration: 78.1 - May 4 - May 17 → ---
Priority: P2 → --

As we are using useState hooks to navigate between screens, Kate suggested using useEffect hooks to send impression ping when index state reflect displayed screen. This way we can do away with Visibility Wrapper that explicitly check for visibilityChange event

https://reactjs.org/docs/hooks-effect.html

Assignee: nobody → pdahiya
Severity: normal → S3
Iteration: --- → 78.2 - May 18 - May 31
Priority: -- → P1
Summary: Use ImpressionsWrapper component for telemetry in aboutwelcome.jsx → Send Impression ping when screen is visible for multistage aboutwelcome.jsx
Summary: Send Impression ping when screen is visible for multistage aboutwelcome.jsx → Send Impression ping when respective screen is visible for multistage aboutwelcome.jsx
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37589d466310
Send Impression telemetry for respective multistage welcome screen r=Mardak
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78

I have verified that the "message_id":"MULTI-STAGE-WELCOME", "message_id":"MULTI-STAGE-WELCOME_AW_GET_STARTED", and "message_id":"MULTI-STAGE-WELCOME_AW_IMPORT_SETTINGS" IMMPRESSION pings are displayed in the Browser Console when each stage of the about:welcome page is shown on the latest Nightly (78.0a1, Build ID 20200528032513) using Windows 10, macOS 10.15.4, and Linux MX 4.19.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.