1619724 - Alert's name should not be inside the table

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Mellina Yonashiro]

Attachment: Screenshot from 2020-03-03 15-31-08.png

Right now the Alert's name in Perfherder's Alert View is inside the table. That is not ideal for screen reader users, as it reads the name of the alert, the table header, and the table content every time it navigates through the table cells.

Ideally, in the HTML structure, it would be outside the table. The style and layout could look the same, but it should not be inside <thead>.

The file to be changed is here: https://github.com/mozilla/treeherder/blob/master/ui/perfherder/alerts/AlertTable.jsx#L203

Comment 1

[shamar knibbs]

can I be assigned this task?

Comment 2

[Mellina Yonashiro]

yes, sure. Thanks!

Comment 3

[shamar knibbs]

Attachment: Screen Shot 2020-03-11 at 5.58.43 PM.png

if im not mistaken you want the entire alert section to be removed in the table?

Comment 4

[Mellina Yonashiro]

Attachment: Screenshot from 2020-03-12 09-59-18.png

Yes, ideally all the gray background part would be out of the table. In the image, this part is inside the yellow stroke.

The challenge here is to do that AND keep the same styling/look.

Comment 5

[shamar knibbs]

Attachment: Screenshot on 2020-03-16 at 22:05:25.png

is this ok?

Comment 6

[shamar knibbs]

is this ok ?

Comment 7

[Mellina Yonashiro]

Yes, just add a light gray background, just like reference and this should be good. I still have to check the markup, but I will do it as soon as you send a pull request.

Comment 8

[shamar knibbs]

Don't I need you to make me a contributor to make a pull request?

Comment 9

[shamar knibbs]

???

Comment 10

[Mellina Yonashiro]

You are already assigned to this bug. The next step is to clone the repository, work on your bug and send a pull request.
Please read this part of the documentation: https://github.com/mozilla/treeherder#contributing

Also, if you need information, add me in the "Request information from...." input, down below.

Comment 11

[shamar knibbs]

I have made a pull request, did you get it ?

Comment 12

[Mellina Yonashiro]

Ahn, not really. Where did you send the PR to? You should send it to the Treeherder Github repository.
Its title should also have this bug number. Please read: https://github.com/mozilla/treeherder#sending-a-pull-request

Comment 13

[shamar knibbs]

would https://github.com/mozilla/treeherder/pulls be it; git pull https://github.com/mozilla/treeherder/pulls ??

Comment 14

[Mellina Yonashiro]

no, that is not it.

That is the step-by-step:

1. Fork Treeherder Github repository to your profile
2. Git clone your fork
3. Create a branch with a name that briefly describes your issue
4. Solve the issue
5. Git add, git commit and git push to your fork and branch. That would be, for example: git push origin name-of-branch
6. On Github, on the page of your fork, click on the "New Pull Request" button.
7. Choose your repository and branch on the right side. Click on "Create Pull Request". Write a description, add the bug number to the title of the PR and click on "Create Pull Request".

If that doesn't solve your problem, I suggest checking out some Git/Github tutorials.

Comment 15

[shamar knibbs]

I have done it, let me know if you got it.

Comment 16

[shamar knibbs]

do you see it

Comment 17

[shamar knibbs]

do you see it

Comment 18

[Mellina Yonashiro]

You didn't write the correct title, that is why the PR wasn't linked.

https://github.com/mozilla/treeherder/pull/6176

I have replied to you there.

Comment 19

[shamar knibbs]

Am I still a contributor to this project? because I noticed that on outreachy that some of the projects have been closed

Comment 20

[Mellina Yonashiro]

Yes, you are still a contributor. This issue has no direct link with Outreachy. If you wish to apply to a project in Outreachy, I suggest you to read that project's description and way of contributing.
If you no longer want to contribute to this issue, please let us know.

Comment 21

[Sparsh Bansal]

I think the the assignee is not working on this issue now , since its been inactive for long . Can i be assigned for this task ?

Comment 22

[Mellina Yonashiro]

I think it's ok Sparsh. Here you go. Let me know if you have any questions.

Comment 23

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6860

Comment 24

[Sarah Clements [:sclements]]

Merged: https://github.com/mozilla/treeherder/commit/cc8f5fc756a8b142930b991c612ee91ced3717f4