Alert's name should not be inside the table
Categories
(Tree Management :: Perfherder, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: yonashiro.mellina, Assigned: sparshbansal3june)
Details
Attachments
(5 files)
Right now the Alert's name in Perfherder's Alert View is inside the table. That is not ideal for screen reader users, as it reads the name of the alert, the table header, and the table content every time it navigates through the table cells.
Ideally, in the HTML structure, it would be outside the table. The style and layout could look the same, but it should not be inside <thead>
.
The file to be changed is here: https://github.com/mozilla/treeherder/blob/master/ui/perfherder/alerts/AlertTable.jsx#L203
Comment 1•4 years ago
|
||
can I be assigned this task?
Reporter | ||
Comment 2•4 years ago
|
||
yes, sure. Thanks!
Reporter | ||
Updated•4 years ago
|
Comment 3•4 years ago
|
||
if im not mistaken you want the entire alert section to be removed in the table?
Reporter | ||
Comment 4•4 years ago
|
||
Yes, ideally all the gray background part would be out of the table. In the image, this part is inside the yellow stroke.
The challenge here is to do that AND keep the same styling/look.
Comment 5•4 years ago
|
||
is this ok?
Comment 6•4 years ago
|
||
is this ok ?
Reporter | ||
Comment 7•4 years ago
|
||
Yes, just add a light gray background, just like reference and this should be good. I still have to check the markup, but I will do it as soon as you send a pull request.
Comment 8•4 years ago
|
||
Don't I need you to make me a contributor to make a pull request?
Comment 9•4 years ago
|
||
???
Reporter | ||
Comment 10•4 years ago
|
||
You are already assigned to this bug. The next step is to clone the repository, work on your bug and send a pull request.
Please read this part of the documentation: https://github.com/mozilla/treeherder#contributing
Also, if you need information, add me in the "Request information from...." input, down below.
Comment 11•4 years ago
|
||
I have made a pull request, did you get it ?
Reporter | ||
Comment 12•4 years ago
|
||
Ahn, not really. Where did you send the PR to? You should send it to the Treeherder Github repository.
Its title should also have this bug number. Please read: https://github.com/mozilla/treeherder#sending-a-pull-request
Comment 13•4 years ago
|
||
would https://github.com/mozilla/treeherder/pulls be it; git pull https://github.com/mozilla/treeherder/pulls ??
Reporter | ||
Comment 14•4 years ago
|
||
no, that is not it.
That is the step-by-step:
- Fork Treeherder Github repository to your profile
- Git clone your fork
- Create a branch with a name that briefly describes your issue
- Solve the issue
- Git add, git commit and git push to your fork and branch. That would be, for example:
git push origin name-of-branch
- On Github, on the page of your fork, click on the "New Pull Request" button.
- Choose your repository and branch on the right side. Click on "Create Pull Request". Write a description, add the bug number to the title of the PR and click on "Create Pull Request".
If that doesn't solve your problem, I suggest checking out some Git/Github tutorials.
Comment 15•4 years ago
|
||
I have done it, let me know if you got it.
Reporter | ||
Comment 18•4 years ago
|
||
You didn't write the correct title, that is why the PR wasn't linked.
https://github.com/mozilla/treeherder/pull/6176
I have replied to you there.
Comment 19•4 years ago
|
||
Am I still a contributor to this project? because I noticed that on outreachy that some of the projects have been closed
Reporter | ||
Comment 20•4 years ago
|
||
Yes, you are still a contributor. This issue has no direct link with Outreachy. If you wish to apply to a project in Outreachy, I suggest you to read that project's description and way of contributing.
If you no longer want to contribute to this issue, please let us know.
Assignee | ||
Comment 21•4 years ago
|
||
I think the the assignee
is not working on this issue now , since its been inactive for long . Can i be assigned for this task ?
Reporter | ||
Comment 22•4 years ago
|
||
I think it's ok Sparsh. Here you go. Let me know if you have any questions.
Comment 23•4 years ago
|
||
Comment 24•4 years ago
|
||
Description
•