Closed Bug 1619729 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22071 - Give blink::CueTimeline a timer for precisely handling cue events

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22071 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22071
Details from upstream follow.

Will Cassella <cassew@google.com> wrote:

Give blink::CueTimeline a timer for precisely handling cue events

Cue-related events (enter, exit, cuechange) are fired up to 250ms late,
and there is a similar latency in their display which is quite
noticeable.

The underlying problem is that we only update cues alongside the
timeupdate event, which is fixed at 4 Hz.

My solution is to add a separate timer to CueTimeline
(CueTimeline::cue_event_timer_) which is given a timeout for the
next cue event based on the current playback position and rate. This
allows for significantly more precise cue timing accuracy without a
significant performance penalty.

Bug: 576310
Change-Id: I675f5f030a68ba9cee10e12b3e79a9b174048193
Reviewed-on: https://chromium-review.googlesource.com/2008079
WPT-Export-Revision: 9db84c755d44f9ffdd525a161142ea5d51095b95

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Component: DOM: Core & HTML → Audio/Video: Playback
Component: Audio/Video: Playback → DOM: Core & HTML

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 2

Chrome

OK : 2
PASS : 1
FAIL : 1

Safari

OK : 1
PASS : 1
FAIL : 1
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4298303bcb61
[wpt PR 22071] - Give blink::CueTimeline a timer for precisely handling cue events, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4298303bcb61

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.