1619766 - Support runtime.openOptionsPage on GeckoView

Status: RESOLVED FIXED

(GeckoView :: Extensions, enhancement, P1)

Description

[dessant]

openOptionsPage is a blocker for whitelisting the Search by Image extension, I couldn't find a way to open the the extension's options using the API or the UI.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Looks like we use BrowserTab.selectOrAddTab which is a Fennec method that doesn't work anymore.

All it's needed here is to call GeckoViewTabBridge.createNewTab for the open_in_tab case and adding a new onOpenOptionsUI delegate java API for the native UI case either in the TabDelegate on in a new delegate.

https://searchfox.org/mozilla-central/rev/91f6c02fcf4c16f78fdc4417f61f192688294066/mobile/android/components/extensions/ext-android.js#53-69

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

so just to clarify the code would be something like this

global.openOptionsPage = extension => {
  const { options_ui } = extension.manifest;
  if (options_ui.open_in_tab) {
    // use GeckoViewTabBridge.createNewTab
  } else {
    // send message
  }
}

where an example for createNewTab is in Comment 1.

Comment 3

[Emily Toop (:fluffyemily)]

We will want to uplift this to 78 when done.

Comment 4

[Eugen Sawin [:esawin]]

Attachment: Bug 1619766 - [1.2] Add WebExtension openOptionsPage support.

Comment 5

[Eugen Sawin [:esawin]]

Attachment: Bug 1619766 - [2.0] Add WebExtension openOptionsPage tests.

Depends on D77901

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa01d9615f6d
[1.2] Add WebExtension openOptionsPage support. r=agi,geckoview-reviewers,robwu
https://hg.mozilla.org/integration/autoland/rev/2b8e623fb40c
[2.0] Add WebExtension openOptionsPage tests. r=geckoview-reviewers,agi

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fa01d9615f6d
https://hg.mozilla.org/mozilla-central/rev/2b8e623fb40c