Remove code for old debugger in openDebugger helper
Categories
(DevTools :: Console, task, P3)
Tracking
(firefox75 fixed)
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: kartikc.918)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
At some point we had 2 different debugger at the same time in the codebase, so we had to adapt for those 2.
This isn't the case anymore, so we can cleanup the openDebugger function in devtools/client/webconsole/test/browser/head.js#778-785
|
||
Updated•4 years ago
|
|
Reporter | |
Comment 3•4 years ago
|
||
Hello KC, thanks for the patch.
For your next patch, make sure to ask if you can work on a bug before starting working on it please.
I can see you worked on another bug, and those good first bug, as their name indicate, should be for people "real" first bug (we have a shortage of those).
That's not a big deal here, but please for your next one, ask before :)
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e387c9fabd1 Remove code for old debugger in openDebugger helper. r=nchevobbe
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)
For your next patch, make sure to ask if you can work on a bug before starting working on it please.
I can see you worked on another bug, and those good first bug, as their name indicate, should be for people "real" first bug (we have a shortage of those).
That's not a big deal here, but please for your next one, ask before :)
I'm sorry, I just wanted to get more familiar with the workflow but I understand what you mean. I will leave them to help out new contributors. Thanks!
Also you can close this issue now.
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Description
•