1619872 - Have a test to ensure EventSource works fine with invalid url in workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, task, P2)

Comment 1

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1619872 - Have a test to ensure EventSource works fine with invalid url in workers after shuting down;

Comment 2

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1619872 - Have a test to ensure EventSource works fine with invalid url in workers after shuting down;

Comment 3

[Tom Tung [:tt, :ttung]]

Comment on attachment 9130729 [details]
Bug 1619872 - Have a test to ensure EventSource works fine with invalid url in workers after shuting down;

Security Approval Request

• How easily could an exploit be constructed based on the patch?: It's a test to reproduce the crash (was fixed in 1614339). So, it should be okay to land this test for ensuring someone won't break it in the future
• Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?: Yes
• Which older supported branches are affected by this flaw?: 68, but the fix has already landed and been verified
• If not all supported branches, which bug introduced the flaw?: None
• Do you have backports for the affected branches?: No
• If not, how different, hard to create, and risky will they be?: The fix has already been laned to 68, 74, and 75. Also, the purpose of this test is to ensure someone won't break it in the future. So, landing this on 76+ should be okay.
• How likely is this patch to cause regressions; how much testing does it need?: It should be unlikely since it's a new test.

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I'm leaving this in the approval queue until 74 is unthrottled for users and has been out for a little bit.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 9130729 [details]
Bug 1619872 - Have a test to ensure EventSource works fine with invalid url in workers after shuting down;

sec-approval+ a=dveditz

Thanks for waiting to land this until after we shipped the fix.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/dc08b292e030ba824eb41e3d2ee983867016e7ef
https://hg.mozilla.org/mozilla-central/rev/dc08b292e030