1619914 - Mark `nsITransaction::DoTransaction()`, `nsITransaction::UndoTransaction()`, `nsITransaction::RedoTransaction()` and its callers as `MOZ_CAN_RUN_SCRIPT`

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Still not recoverd perfectly)]

Attachment: Bug 1619914 - part 1: Make each transaction class grab their members with local variable before touching the DOM tree r=m_kato!

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Still not recoverd perfectly)]

Attachment: Bug 1619914 - part 2: Mark transaction class methods and their caller methods as `MOZ_CAN_RUN_SCRIPT r=m_kato!

Depends on D69302

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/876b1031a6ae
part 1: Make each transaction class grab their members with local variable before touching the DOM tree r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d3816f82c0b9
part 2: Mark transaction class methods and their caller methods as `MOZ_CAN_RUN_SCRIPT r=m_kato

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets for causing gtest failures regarding TransactionManager.

Backout link: https://hg.mozilla.org/integration/autoland/rev/efd779b64b3fadfea4b6569490a3cd5546acba1a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=676749&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=efd779b64b3fadfea4b6569490a3cd5546acba1a&fromchange=d3816f82c0b9d4ceca0bb2ad177694164ed0921f&selectedJob=296047415

Failure log:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296047415&repo=autoland&lineNumber=26796
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296046188&repo=autoland&lineNumber=28305

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce2087ddab5c
part 1: Make each transaction class grab their members with local variable before touching the DOM tree r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b9ebe58001d7
part 2: Mark transaction class methods and their caller methods as `MOZ_CAN_RUN_SCRIPT r=m_kato

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ce2087ddab5c
https://hg.mozilla.org/mozilla-central/rev/b9ebe58001d7

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f511a27de53a
mark AddMarkAllReadUndoAction with MOZ_CAN_RUN_SCRIPT to make Thunderbird build again. rs=bustage-fix