Closed Bug 1619924 Opened 4 years ago Closed 4 years ago

Instant Evaluation (aka eager evaluation) not showing correct values after using Space key on different function while autocomplete is opened

Categories

(DevTools :: Console, defect, P1)

75 Branch
Desktop
All
defect

Tracking

(firefox-esr68 unaffected, firefox73 disabled, firefox74 disabled, firefox75- verified, firefox76 verified)

VERIFIED FIXED
Firefox 76
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- disabled
firefox74 --- disabled
firefox75 - verified
firefox76 --- verified

People

(Reporter: atrif, Assigned: nchevobbe)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image evaluation_01.gif

Affected versions

  • 75.0a1 (20200303214128)

Affected platforms

  • Ubuntu 18.04
  • Windows 10x64
  • macOS 10.15

Steps to reproduce

  1. Open Firefox and Web Console.
  2. Set a=1 and b=2.
  3. Write a*b and use the down arrow key to go to the “blur” item on the autocomplete popup.
  4. Hit Space key.

Expected result

  • The result for evaluation is 2.

Actual result

  • The result is NaN.

Regression Range

  • I will search for one ASAP if there is one

Notes

  • Attached a screen recording.
Has Regression Range: --- → yes
Has STR: --- → yes
Regressed by: 1608369
Priority: -- → P1
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

There was a bug if you had a given item selected in the
autocomplete popup, but would then type a character that
would dismiss the popup.
This was because of an extra check that was made in the
reducer to ensure that the result of an eager evaluation
was matching the expression that requested it.
This check was here from the beginning of eager evaluation,
but isn't needed anymore as we have some guarantee of order
for the eager evaluation.

A test case is added to ensure this is working as expected.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/311a5dc0cc71
Fix instant evaluation result when dismissing popup suggestion. r=Honza.

[Tracking Requested - why for this release]: Can degrade the experience for the newly added instant eval feature.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

Comment on attachment 9133508 [details]
Bug 1619924 - Fix instant evaluation result when dismissing popup suggestion. r=Honza.

Beta/Release Uplift Approval Request

  • User impact if declined: Erroneous instant evaluation result in the webconsole
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open Firefox and Web Console.
  1. Execute a=1; b=2.
  2. Write a*b and use the down arrow key to go to the “blur” item on the autocomplete popup.
  3. Hit Space key.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): DevTools only, covered by automated test
  • String changes made/needed:
Attachment #9133508 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9133508 [details]
Bug 1619924 - Fix instant evaluation result when dismissing popup suggestion. r=Honza.

approved for 75.0b5

Attachment #9133508 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I got a conflict when trying to uplift this to beta.
devtools/client/webconsole/actions/input.js

conflict with https://bugzilla.mozilla.org/show_bug.cgi?id=1619302 which didn't land on beta

Flags: needinfo?(nchevobbe)

we should put this block in the uplifted patch: https://searchfox.org/mozilla-central/rev/d6f957415cf009995ecb539ef1425316d82164a9/devtools/client/webconsole/actions/input.js#244-251

(we can't uplift Bug 1619302 because there are too many dependencies)

Flags: needinfo?(nchevobbe)

Fix verified with Firefox 76.0a1 (20200318041411) on Windos 10x64, macOS 10.15 and Ubuntu 18.04.

Verified with Firefox 75.0b6 (20200318131458) from comment 11 on Windows 10x64, macOS 10.15 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: