1619948 - Put LSNG behind the EARLY_BETA_OR_EARLIER flag

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, task, P1)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

We uplift a patch to disable LSNG at the end of each beta cycle and almost forgot to do it in a couple of releases. LSNG should be behind the EARLY_BETA_OR_EARLIER flag so as that it gets disabled automatically in the middle of the beta cycle. When we decide that we are ready to ship it, we will uplift a patch activating it past the mid beta cycle point.

Comment 1

[Jan Varga [:janv]]

Ok.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

test_localStorageQuotaSessionOnly.html will need to be adjusted with LSNG disabled, see bug 1611317.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This bug is tracked by a release manager but with a small severity so change it to major.
For more information, please visit auto_nag documentation.

Comment 4

[Julien Cristau [:jcristau]]

Attachment: Bug 1619948 - turn off LSNG for 75.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1619948 - Put LSNG behind the EARLY_BETA_OR_EARLIER flag; r=asuth

Comment 6

[Masatoshi Kimura [:emk]]

Will Beta users storage backend flip back and forth between legacy-LS and LSNG? (when Beta becomes not "early" and when Beta merges to the next version)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f0b527ef54c
Put LSNG behind the EARLY_BETA_OR_EARLIER flag; r=asuth

Comment 8

[Julien Cristau [:jcristau]]

Please request uplift to beta when you get a chance.

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/1f0b527ef54c

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Masatoshi Kimura [:emk] from comment #6)

Will Beta users storage backend flip back and forth between legacy-LS and LSNG? (when Beta becomes not "early" and when Beta merges to the next version)

Yes. This works out fine because:

• When enabled, LSNG migrates old LS data as it is needed and issues writes to both the old single database and the new per-origin databases.
• When disabled, LSNG support logic knows to wipe out the new databases that will no longer be used. (This is necessary for privacy and data staleness concerns.)

As a result, the change is seamless to users[1].

1: As long as QuotaManager isn't broken in the profile.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9135161 [details]
Bug 1619948 - Put LSNG behind the EARLY_BETA_OR_EARLIER flag; r=asuth

let's get this and the followup in for 75.0b10

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e50531f8c32