Closed Bug 1619985 Opened 1 year ago Closed 1 year ago

update buildhub.json generating code to set win64-aarch64 platform correctly

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(firefox76 fixed)

RESOLVED FIXED
Tracking Status
firefox76 --- fixed

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(1 file)

Right now, we're setting it to "win64", which is the same thing that regular 64-bit windows builds have, leading to some confusion in Buildhub. We should probably set this to "win64-aarch64", but I don't have terribly strong feelings about the specific name.

We did use the name "win64-aarch64" until about a year ago, so I do have strong feelings that that's the name we should use again. :)

(In reply to Sven Marnach from comment #1)

We did use the name "win64-aarch64" until about a year ago, so I do have strong feelings that that's the name we should use again. :)

I'm surprised by this. It looks like we use MOZ_PKG_PLATFORM to populate the buildhub.json platform (https://searchfox.org/mozilla-central/source/toolkit/mozapps/installer/informulate.py#25, https://searchfox.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#119). And this has been strictly "win64" since 2015: https://hg.mozilla.org/mozilla-central/annotate/921109cf8981f8f665ee8d91689f492d12ba5795/toolkit/mozapps/installer/package-name.mk#l24

Adding a couple of people that might have insight into the best path forward here.

Flags: needinfo?(mtabara)
Flags: needinfo?(mshal)

I'm not sure, but it looks like froydnj intended it to be win64 in bug 1494717, so maybe he knows.

Flags: needinfo?(mshal) → needinfo?(nfroyd)

I was making it "win64" because that was the easiest path forward at the time. I would be all for naming it win64-aarch64 if that makes life easier for people.

Flags: needinfo?(nfroyd)
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Pushed by bhearsum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73e0bda4e6ec
use a unique package platform for aarch64 windows builds r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Flags: needinfo?(mtabara)
You need to log in before you can comment on or make changes to this bug.