1620054 - [wpt-sync] Sync PR 22091 - [IndexedDB] Fix crash when storing native file system handles using inline keys.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 22091 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22091
Details from upstream follow.

Marijn Kruisselbrink <[e-mail]> wrote:

[IndexedDB] Fix crash when storing native file system handles using inline keys.

IndexedDB assumes it can non-destructively deserialize a SerializedScriptValue,
however our implementation for deserializing native file system handles actually
modified the SSV in a way that violated that assumption. This fixes this by
cloning the handles in the SSV rather than consuming them.

Bug: 1058419
Change-Id: I11ddfef757849941cc26e920eadb9022f7e138a4
Reviewed-on: https://chromium-review.googlesource.com/2088218
WPT-Export-Revision: 1f9863da94b740600e961f0c5868c275e19e5495

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6f0ed52e83daf4245812cb33eb03247066a3843

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 47 tests

Status Summary

Firefox

OK : 2
PASS : 45
FAIL : 10

Chrome

CRASH: 2

Safari

OK : 2
FAIL : 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/native-file-system/sandboxed_FileSystemBaseHandle-IndexedDB.tentative.https.any.html
Store handle in IndexedDB and read using a cursor.: FAIL (Safari: FAIL)
Store handle in IndexedDB using inline keys.: FAIL (Safari: FAIL)
Store handles and blobs in IndexedDB.: FAIL (Safari: FAIL)
Store handle in IndexedDB and read from new transaction.: FAIL (Safari: FAIL)
Store handle in IndexedDB and read from pending transaction.: FAIL (Safari: FAIL)
/native-file-system/sandboxed_FileSystemBaseHandle-IndexedDB.tentative.https.any.worker.html
Store handle in IndexedDB and read using a cursor.: FAIL (Safari: FAIL)
Store handle in IndexedDB using inline keys.: FAIL (Safari: FAIL)
Store handles and blobs in IndexedDB.: FAIL (Safari: FAIL)
Store handle in IndexedDB and read from new transaction.: FAIL (Safari: FAIL)
Store handle in IndexedDB and read from pending transaction.: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edd1b7f027f4
[wpt PR 22091] - [IndexedDB] Fix crash when storing native file system handles using inline keys., a=testonly
https://hg.mozilla.org/integration/autoland/rev/c4ccec7390e3
[wpt PR 22091] - Update wpt metadata, a=testonly

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/edd1b7f027f4
https://hg.mozilla.org/mozilla-central/rev/c4ccec7390e3