1620194 - Stop registering devtools test actor dynamically

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

Support for actors loaded dynamically such as the test-actor make it very hard to simplify the tab-descriptor <-> target interaction.

Most descriptor/targets couple can rely on a very simple caching handled on the client side, but because of the test actor (which is only used for tests debugging tabs...) we can't follow the same pattern.

I suggest we register the actor regularly, simply putting it behind flag.testing to avoid errors when we are not running tests.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1620194 - Stop registering test actor dynamically

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1620194 - Remove actor-registry actor

Depends on D65564

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1620194 - Remove test-actor-registry and expose simplified helpers in shared-head.js

Depends on D65570

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9f4dc32ef43
Stop registering test actor dynamically r=ochameau
https://hg.mozilla.org/integration/autoland/rev/0bbcb1d56f62
Remove actor-registry actor r=ochameau
https://hg.mozilla.org/integration/autoland/rev/7236deddd85a
Remove test-actor-registry and expose simplified helpers in shared-head.js r=ochameau

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34cc90f6bbaf
Fix eslint violation in browser_connectToFrame.js

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b9f4dc32ef43
https://hg.mozilla.org/mozilla-central/rev/0bbcb1d56f62
https://hg.mozilla.org/mozilla-central/rev/7236deddd85a
https://hg.mozilla.org/mozilla-central/rev/34cc90f6bbaf