1620206 - Account Manager: S/MIME cert selection not saved if closing

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Kai Engert (:KaiE:)]

You need a configured S/MIME certificate to reproduce this bug.

Open account manager
Security tab

If certs are selected, press clear on both.
If no certs are selected, make a selection

Close the account manager tab
Restart Thunderbird
Open the account manager tab

Expected result: The last configuration change to the S/MIME certs is still active

Actual result: The last change was ignored, still shows previous state

Workaround:
Click a different account manager tab prior to closing the prefs.

Question:
Is there a JS function that we must call after the selection is made, to make the change immediately persistent?

Comment 1

[Jorg K (CEST = GMT+2)]

I expect more issues like this. Aceman and I have discussed issue surrounding this at length when the AM was already in a tab in bug 1096006 for a while and there was a lot of code that made sure values were saved and consistency checks were run when switching panes in the AM, switching tabs or closing the AM tab.

Comment 2

[Kai Engert (:KaiE:)]

There are no longer "ok/cancel" buttons for account manager prefs.

I conclude that any click/change inside account manager is supposed to be immediately persistent, right?

If yes, then all JS code in account manager that updates elements/flags needs to immediately call a save function, right?

Comment 3

[Jorg K (CEST = GMT+2)]

There is a lot of fine-print to this, see the bug I mentioned.

Comment 4

[Alessandro Castellani [:aleca]]

Pinging Richard to see if he can handle it, otherwise I can take care of it as a priority early next week.

Comment 5

[Khushil Mistry [:khushil324]]

I will take this as I know the problem.

Comment 6

[Alessandro Castellani [:aleca]]

(In reply to Khushil Mistry [:khushil324] from comment #5)

I will take this as I know the problem.

Sweet, thank you so much!

Comment 7

[Khushil Mistry [:khushil324]]

(In reply to Kai Engert (:KaiE:) from comment #2)

There are no longer "ok/cancel" buttons for account manager prefs.

I conclude that any click/change inside account manager is supposed to be immediately persistent, right?

If yes, then all JS code in account manager that updates elements/flags needs to immediately call a save function, right?

We have assigned onchange/oncommand listener to all the input elements (checkbox, input, menulist, textarea, radiogroup, and richlistbox) in Account Manager Tab: https://searchfox.org/comm-central/source/mailnews/base/prefs/content/AccountManager.js#150

So we have onchange listener assigned to all the input elements in "Security" tab. But here, we are directly assigning a value to input like input.value = "xyz" through javascript which will not trigger onchange function.

To save the settings, we need to dispatch an event: window.dispatchEvent(new CustomEvent("prefchange")); which will trigger the changes globally.

So, whenever we are directly assigning value to input, we need to dispatch a "prefchange" event at the right place.

Comment 8

[Khushil Mistry [:khushil324]]

Attachment: Bug-1620206_SMIME-cert-selection-not-saved-0.patch

Comment 9

[Kai Engert (:KaiE:)]

Khushil, thanks a lot, the change to mailnews/extensions/smime/content/am-smime.js works for me!

Note we don't need the change to mail/extensions/openpgp/content/ui/am-enigprefs.js - that file is currently inactive, and I'm going to remove it in bug 1603809.

Comment 10

[Kai Engert (:KaiE:)]

Attachment: Bug-1620206_SMIME-cert-selection-not-saved.patch

The subset of Khushil's patch that we need.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/09cf06df9f5d
Account Manager: S/MIME cert selection not saved if closing. r=kaie DONTBUILD