1620243 - Implement console message listening via the ResourceWatcher API on the actor side

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

While bug 1576624 implement a 100% client side version of the Resources API,
which demonstrates that it would work against old Firefox versions.
This bug will focus on implementing this on the actor side.

Implementing it on the actor side would allow:

• To get rid of the quite complex LegacyImplementations pieces of code introduced in bug 1576624, once this bug reaches Firefox release channel.
• In coordination to bug 1593937, this will allow listening to resources before the document, process or worker would start executing anything.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Watch console messages resources from the server side.

Comment 3

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 4

[Alexandre Poirot [:ochameau]]

This bug will be the first case of server side listening of a resource, applied to console messages.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Wait for already existing resources.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Stop using the console actor and directly use ConsoleAPIListener

Comment 7

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Instantiate only one ResourceWatcher in the console stubs test.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Use queries instead of relying on sharedData change event.

This would probably better match a potential followup where we are using
BrowsingContext attributes/events dedicated to DevTools instead of sharedData.

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Use a registry as JSM in order to be the single source of truth.

This is to workaround races when reading/writting sharedData from multiple callsites in the same process.

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Add `resourceType` attribute to each resource and emit list of resources.

Comment 12

[Phabricator Automation]

Comment on attachment 9149846 [details]
Bug 1620243 - Instantiate only one ResourceWatcher in the console stubs test.

Revision D75790 was moved to bug 1640641. Setting attachment 9149846 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9151440 [details]
Bug 1620243 - Add resourceType attribute to each resource and emit list of resources.

Revision D76672 was moved to bug 1640641. Setting attachment 9151440 [details] to obsolete.

Comment 14

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Pass BrowsingContextTargetActor docShell via its constructor.

Comment 15

[Alexandre Poirot [:ochameau]]

I broke logpoints again:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=addc79a6c31a289d9edc56af1133355288a32b42
But if we ignore that, try is green with the latest changes.

Comment 16

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Watch console messages resources from the server side.

Comment 17

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Fix the key used for DevToolsFramesChild._connections map.

Comment 18

[Alexandre Poirot [:ochameau]]

DAMP reports no very significant change.
May be a small improvement on console.expand test:
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&newRevision=8fd81d533f24a31395af47083bd3b786db5984e0&originalSignature=1910071&newSignature=1910071&framework=12&originalRevision=689429e8c00efba18fe6ce0bf0588c92c820140b

Comment 19

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620243 - Read sharedData only when the document starts loading

This is an alternative to how I addressed this issue:
https://phabricator.services.mozilla.com/D77441?id=290263#inline-451203

We pass the list of watched resources from the parent process, when calling WatcherActor.watchTargets, instead of relying on sharedData.
So that, sharedData is really only read when the document starts loading, from DevToolsFrameChild.instantiate.
i.e. only where we really have to depend on sharedData.

If you are happy with this patch, I'll merge it into the previous one.

Comment 20

[Alexandre Poirot [:ochameau]]

One last try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=244372a54ed46e91376ca227190b0497d1fa4eb0

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18c4fee3723c
Pass BrowsingContextTargetActor docShell via its constructor. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/6700501368b1
Fix the key used for DevToolsFramesChild._connections map. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/12624e4520a1
Watch console messages resources from the server side. r=nchevobbe,jdescottes

Comment 22

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/18c4fee3723c
https://hg.mozilla.org/mozilla-central/rev/6700501368b1
https://hg.mozilla.org/mozilla-central/rev/12624e4520a1