Closed Bug 1620259 Opened 5 years ago Closed 4 years ago

Share buttons not working and other breakage on m.sport.ro with ETP - Strict enabled

Categories

(Core :: Privacy: Anti-Tracking, defect, P3)

Unspecified
Android
defect

Tracking

()

RESOLVED DUPLICATE of bug 1628176
Tracking Status
firefox87 --- affected

People

(Reporter: oanaarbuzov, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [tp-yellowlist-active][tp-embedded-media][tp-shim-content])

Attachments

(1 file)

Attached image StrictVSStandard.jpg

Environment:
Browser / Version: Firefox Nightly Preview 200305 (🦎: 75.0a1-20200304084140)
Operating System: Huawei P20 Lite (Android 8.0.0) - 1080 x 2280 pixels, 19:9 ratio (~432 ppi density)

Steps to Reproduce:

  1. Navigate https://m.sport.ro/virale/lasati-l-naibii-de-play-off-ea-iti-face-pielea-de-gaina-mai-ceva-ca-imnul-champions-league-fata-care-le.html
  2. Scroll down to the end of the article.
  3. Tap "Activeaza comentariile" button.
  4. Observe behavior.

Expected Behavior:
"Comments" section is displayed.

Actual Behavior:
Nothing happens. "Comments" section is not displayed.

Note:

  1. With "Standard" protection the "Comments" section is displayed.
  2. Screenshot attached.

I'm no longer seeing a comments section on their articles, just a Facebook Like and Share button and a Tweet button (and oddly, Chrome does not even show the Tweet button). In strict mode I only see an unstyled "Tweet" link.

I also see that I cannot press the escape key to exit out of their image gallery after I click a left/right arrow to begin viewing images, so there are general issues here that do not seem related to Facebook comments anymore.

Summary: Unable to activate "Comments" section on m.sport.ro with ETP - Strict enabled → Share buttons not working and other breakage on m.sport.ro with ETP - Strict enabled

Facebook's SDK script converts elemnts with .fb-like.fb-widget dynamically when loaded into iframes like this:

<iframe name="f169085ab210cde" data-testid="fb:like Facebook Social Plugin" title="fb:like Facebook Social Plugin" allowtransparency="true" allowfullscreen="true" scrolling="no" allow="encrypted-media" style="border: medium none; visibility: hidden;" src="https://www.facebook.com/v3.2/plugins/like.php?action=like&amp;app_id=&amp;channel=https%3A%2F%2Fstaticxx.facebook.com%2Fconnect%2Fxd_arbiter.php%3Fversion%3D46%23cb%3Df240e4140bd2cd%26domain%3Dwww.sport.ro%26origin%3Dhttps%253A%252F%252Fwww.sport.ro%252Ff1bd4b4e34da86%26relation%3Dparent.parent&amp;container_width=0&amp;href=https%3A%2F%2Fwww.sport.ro%2Fvirale%2Flasati-l-naibii-de-play-off-ea-iti-face-pielea-de-gaina-mai-ceva-ca-imnul-champions-league-fata-care-le.html&amp;layout=button&amp;locale=en_US&amp;sdk=joey&amp;share=true&amp;show_faces=false&amp;size=large" width="1000px" height="1000px" frameborder="0"></iframe>

So we could provide our own placeholder quite easily.

The Tweet widget is loaded by just loading their script inside of their own placeholder:

<div class="twitter-widget">
  <a href="https://twitter.com/intent/tweet" class="twitter-share-button" data-size="large" data-show-count="false">Tweet</a>
  <script async="" src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
</div>

This can likewise be shimmed with our own placeholder.

Blocks: tp-twitter, 1446243
No longer blocks: tp-breakage
Whiteboard: [tp-yellowlist-active][tp-embedded-media][tp-shim-content]

The issue still occurs, with ETP - Strict, comments are not displayed.
https://prnt.sc/yer19r

Tested with:
Browser / Version: Firefox Nightly 210204 (🦎 87.0a1-20210203093146)
Operating System: Huawei P20 Lite (Android 8.0.0) - 1080 x 2280 pixels, 19:9 ratio (~432 ppi density), Samsung Galaxy S6 Edge (Android 7.0) - 1440 x 2560 pixels (~577 ppi pixel density),

If embedded Twitter contents require cookies from twitter.com (third party cookie) to embed contents, this is the right behavior.

No longer blocks: tp-twitter
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: