1620299 - URLBar Interventions should honor policy (and be able to be disabled by policy)

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Mike Kaply [:mkaply]]

Currently URLBar Interventions tells users they can refresh Firefox, but if refresh has been turned off by policy, they cannot.

The same is true of the update policy. If update is turned off, that policy should not show.

Any interventions that intersect with policy should check policy to see if they should be displayed.

In addition, we should provide a policy to completely turn off interventions. This can go in the new "UserMessaging" section of policy.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

We also have tips, for when you are on the new tab page, or you visit a default search engine home page, suggesting to search in the urlbar, but those already respect browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features... Do we have a policy setting that pref?

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

[Tracking Requested - why for this release]: Kaply said we would like to have this policy in 75.

Comment 3

[Mike Kaply [:mkaply]]

Yes, we already have a policy for that.

https://searchfox.org/mozilla-central/rev/13b081a62d3f3e3e3120f95564529257b0bf451c/browser/components/enterprisepolicies/Policies.jsm#1563

Although Somehow I got the policy backwards. No idea how that made it past folks. I'll fix that when I add this.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Actually, we have a temporary pref to disable interventions, but not a pref that is going to stay forever... This may need to add one.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Bug 1620299 - Add policy for URL bar interventions. r?mak

Comment 6

[Bridget Kaluzny]

for release 75, but should not block the 74 experiment.

Comment 7

[Julien Cristau [:jcristau]]

Is this ready to land?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c92b88921940
Add policy for URL bar interventions. r=mak

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c92b88921940

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 9132371 [details]
Bug 1620299 - Add policy for URL bar interventions. r?mak

Beta/Release Uplift Approval Request

• User impact if declined: Enterprises can't disable urlbar messages (and some messages relate to things that won't work)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Add a policy like this:

{
  "policies": {
    "UserMessaging": {
       "UrlbarInterventions": false
    }
  }
}

Verify that when you type refresh Firefox or download Firefox, no messages show up

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mainly policy related.
• String changes made/needed:

Comment 11

[Adrian Florinescu [:aflorinescu]]

Additional steps to comment 10, in case someone else will want to verify this:

1. Create a folder called "distribution" in the directory where Fx is installed. (while firefox closed)
2. Create a file policies.json in which you add the policy from comment 10. (while firefox closed)
3. Fire up firefox.
4. type any intervention into the address bar: e.g.: update firefox, cache firefox, refresh firefox or any of the keywords listed here

Verified as fixed on:

     Windows 10
     Ubuntu 18.04
     macOS 10.13.6

with:

     76.0a1 2020-03-18

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9132371 [details]
Bug 1620299 - Add policy for URL bar interventions. r?mak

approved for 75.0b6, thanks

Comment 13

[Adrian Florinescu [:aflorinescu]]

Search Tips are not disabled by "UrlbarInterventions": false (although it makes sense given the name of the policy and the title of this issue - which is implementing intervention policy), but its unclear to me if there should be any Search Tips policies?

Comment 14

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

search tips are disabled through the browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features pref, that is supported by policies too (FeatureRecommendations).

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f3c060cedafb

Comment 16

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on:

     Windows 10
     Ubuntu 18.04
     macOS 10.13.6

with:

     75.0b9 	2020-03-25