1620302 - Remove the undo option after uninstalling an add-on

Status: NEW

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Mark Striemer [:mstriemer]]

All of the places where an add-on can be uninstalled now prompt the user for confirmation before uninstalling the add-on. Since we've already asked for confirmation we can remove the undo option.

Comment 1

[Andrew Swan [:aswan]]

There's a ton of complexity in the AddonManager backend that can be removed if this is done. Does this bug cover all that or just the front-end bits? It seems like the two tasks are pretty different and would probably warrant separate bugs?

Comment 2

[Mark Striemer [:mstriemer]]

This was intended for the UI. I just filed another bug to remove it from the backend since this would need to happen first.

Comment 3

[Jayati Shrivastava]

Hi! I would like to work on this :)

Comment 4

[Jayati Shrivastava]

Attachment: Bug 1620302- Uninstall addon immediately rather than putting in pending state. r=mstriemer

Comment 5

[Jayati Shrivastava]

May I also work on the backend for this, if it hasn't been fixed yet ? :)

Comment 6

[Jayati Shrivastava]

For the backend part, do we need to remove all the cancelUninstall and related methods?

Comment 7

[Jayati Shrivastava]

Are we aiming to "completely" remove the functionality of cancelling the uninstallation of the addon.

Comment 8

[Johann Hofmann [:johannh]]

I don't know, this is a question for Mark, really :)

Comment 9

[Mark Striemer [:mstriemer]]

This bug is to stop putting add-ons into the pending uninstall state and remove any UI associated with that. I think we'll run into some trouble regarding the abuse reports as they expect to have an add-on object available and if we have entirely removed the add-on when we open the UI there might not be one available. That could be a blocker here for now but I'd need to investigate that more.

Bug 1620440 is tracking removing support for pending uninstalls from the backend, but I can't comment too much on how that would be accomplished. I suspect updating the backend would require a decent amount of knowledge of how the AddonManager code is structured, as I understand there are quite a few edge cases in a lot of places.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.