1620325 - Add browser telemetry sessionId to telemetry pings from about:welcome, about:home and about:newtab

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add browser telemetry sessionId to event and impression pings sent from about:welcome ( both simplified and existing), about:home and about:newtab.

https://docs.telemetry.mozilla.org/concepts/terminology.html?highlight=session#terminology

sessionId data can be seen at about:telemetry#session-info-tab -> sessionId .

Example of sessionId inside database https://sql.telemetry.mozilla.org/queries/68940/source

sessionId browser telemetry is needed for tracking metrics in the same session in which the about:welcome experience was shown to the user and a hard requirement for do no harm experiment.

See Tech Plan https://docs.google.com/document/d/1j6VtrpBEUydT03dHCQrsFK1mVHnGnHbvZg2fxdAlckQ/edit# -> First Session Metrics data requirement

Comment 1

[Nan Jiang [:nanj]]

Specifically, we will add a new column called browser_session_id (as session_id is already defined in some activity-stream tables) to messaging_system.onboarding and activity_stream.events.

Su, does that suffice for the do-no-harm experiment now?

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/509

Comment 3

[Su-Young Hong]

yes, that will be sufficient for this experiment!

Comment 4

[Nan Jiang [:nanj]]

Attachment: Bug 1620325 - Add browser sessionId to Onboarding and Activity-Stream event pings r=pdahiya

Comment 5

[Nan Jiang [:nanj]]

Attachment: data_review_request_browser_session_id.txt

Hi chutten, could you take a look at this telemetry addition, please?

You can find the document in the patch

Thanks!

Comment 6

[Nan Jiang [:nanj]]

Attachment: Bug 1620325 - Review fixes r=pdahiya

Depends on D65597

Comment 7

[Chris H-C :chutten]

Comment on attachment 9131275 [details]
data_review_request_browser_session_id.txt

PRELIMINARY NOTES:
Q1 should be answered with a list of questions that can only be answered by the addition of the new data collection. The answer to Q2 contains one, so this review will proceed.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is documented in its [in-tree documentation](https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/v2-system-addon/data_dictionary.html)

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences and Activity Stream's preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nan Jiang is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8af21fad064f
Add browser sessionId to Onboarding and Activity-Stream event pings r=pdahiya

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8af21fad064f

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the "browser_session_id" value was added to the event and impression pings from the "about:welcome", "about:home" and "about:newtab" pages.
Verified using the latest Firefox Nightly (76.0a1 Build ID - 20200309215254) and latest Firefox Beta (75.0b1 Build ID - 20200309155231) installed on Windows 10 x64, Mac 10.15.2, and Ubuntu 18.04 x64.