Implement the `SetMediaMetadata()` for MPRISServiceHandler and WindowsSMTCProvider
Categories
(Core :: Audio/Video: Playback, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: alwu, Assigned: MeFisto94)
References
Details
Attachments
(4 files)
After bug1592037, we are able to propagate the metadata from media session to the platform-specific event source, so we should display that metadata on virtual control interface by using platform-specific API.
|
Reporter | |
Comment 1•4 years ago
|
||
Marc, are you interested in implementing this one?
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Just one question about the contents of MediaMetadataBase:
What do they contain if metadata is only set partially? Empty or null strings?
Or will the Controller ensure that those properties are always available and I can just set them?
|
|
Reporter | |
Comment 3•4 years ago
|
||
(In reply to Marc Streckfuß [:MeFisto94] from comment #2)
Just one question about the contents of MediaMetadataBase:
What do they contain if metadata is only set partially? Empty or null strings?
Or will the Controller ensure that those properties are always available and I can just set them?
I will ensure that at least metadata should contain title and artwork in bug1615112, I'll go to implement that after landing bug1592037.
Thank you!
|
|
Assignee | |
Comment 4•4 years ago
|
||
But that means the artist remains "empty"?
My question just is: How should I check for not set metadata elements?
Like in the previous approach we had Maybe's but the MediaMetadataBase does not contain Maybes
|
|
Reporter | |
Comment 5•4 years ago
|
||
If the artist name is empty, then we would replace it with website's title. If the artwork is empty, then we would replace it with default favicon icon.
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D65801
|
|
Assignee | |
Comment 8•4 years ago
|
||
Depends on D66389
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 9•4 years ago
|
||
|
||
Comment 10•4 years ago
|
||
Pushed by marc.streckfuss@gmail.com: https://hg.mozilla.org/integration/autoland/rev/23cb383004f6 part1: Implement SetMediaMetadata() for the MPRISServiceHandler, r=alwu https://hg.mozilla.org/integration/autoland/rev/3bd0b38c4220 part2: Propagate SetMediaMetadata from the MediaControlKeysManager to the native event source, r=alwu https://hg.mozilla.org/integration/autoland/rev/dbf8e1cfaa16 part3: Cosmetic Changes to MediaControlKeysManager, r=alwu https://hg.mozilla.org/integration/autoland/rev/3967e9ba3e97 part4: Implement SetMediaMetadata() for the WindowsSMTCProvider, r=alwu
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/23cb383004f6
https://hg.mozilla.org/mozilla-central/rev/3bd0b38c4220
https://hg.mozilla.org/mozilla-central/rev/dbf8e1cfaa16
https://hg.mozilla.org/mozilla-central/rev/3967e9ba3e97
Description
•