Closed Bug 1620403 Opened 6 years ago Closed 6 years ago

Could `clang-format` run as part of `mach lint`?

Categories

(Developer Infrastructure :: Lint and Formatting, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1466070

People

(Reporter: chutten, Unassigned)

Details

(( Not quite entirely unrelated to bug 1514279 ))

I generally remember to lint things locally but often forget clang-format. This is probably because I'm just a bad person. Unfortunately I'm not likely to become a better person as quickly as tooling can improve, so I'm asking here:

Could clang-format become part of mach lint? That way I'll only have one thing I need to remember.

Yeah, we should probably to that with clang-format-10.
It adds a new option (--dry-run) to do it
https://prereleases.llvm.org/10.0.0/rc3/tools/clang/docs/ReleaseNotes.html#clang-format

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE

This could also be duped to bug 1511122.

Though there's certainly precedent of masquerading formatters as linters in mach lint, so it can go either way.

Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.