1620453 - Properly promote unexpected plugin wmode values to direct on Windows

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[David Parks [:handyman]]

The only wmode values that we should send to Flash Player (on Windows) are "direct", "opaque" and "transparent". Any other values are either out of date or illegal. In particular, we want "window" and "gpu" modes (as well as any unexpected values such as "default" or "foo") to be promoted to "direct" by Firefox. We handle "window" and "gpu" correctly, but not the rest. This bug is to change ForceDirect [1] to fix that.

[1] https://searchfox.org/mozilla-central/rev/13b081a62d3f3e3e3120f95564529257b0bf451c/dom/plugins/ipc/PluginModuleParent.cpp#2065

Comment 1

[David Parks [:handyman]]

Attachment: Bug 1620453: Force Windows plugin wmode to be direct, opaque or transparent r=aklotz

This code always intended to force wmode to be one of these modes (bug 1340276) but was not robust to unexpected wmode values (e.g. "default"). Unexpected values are now promoted to "direct".

Comment 2

[David Parks [:handyman]]

The wmode behavior is explained here: https://wiki.mozilla.org/Plugins/Async_Drawing#Windows

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Aaron, review ping

Comment 5

[Jeff Muizelaar [:jrmuizel]]

David can this land?

Comment 6

[David Parks [:handyman]]

Yup. Thanks for the reminder.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de94a3c40ad2
Force Windows plugin wmode to be direct, opaque or transparent r=aklotz

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/de94a3c40ad2