1620458 - On Android, WebGL examples don't work when webrender is enabled

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[John Lin [:jhlin][:jolin]]

The MDN example[1] and videojs-vr examples[2] show black screen. After setting the gfx.webrender.force-disabled to true, The contents plays fine.

The log show SurfaceTexture errors when copying contents from the chrome process to the content process:

03-05 23:55:08.154  1633  1664 E GLConsumer: [SurfaceTexture-0-1633-16] attachToContext: GLConsumer is already attached to a context
03-05 23:55:08.154  1633  1664 W System.err: java.lang.RuntimeException: Error during attachToGLContext (see logcat for details)
03-05 23:55:08.154  1633  1664 W System.err: 	at android.graphics.SurfaceTexture.attachToGLContext(SurfaceTexture.java:294)
03-05 23:55:08.154  1633  1664 W System.err: 	at org.mozilla.gecko.gfx.GeckoSurfaceTexture.attachToGLContext(GeckoSurfaceTexture.java:91)
03-05 23:55:08.154  1633  1664 W System.err: 	at org.mozilla.gecko.gfx.GeckoSurfaceTexture$NativeGLBlitHelper.blit(Native Method)
03-05 23:55:08.154  1633  1664 W System.err: 	at org.mozilla.gecko.gfx.GeckoSurfaceTexture.takeSnapshot(GeckoSurfaceTexture.java:307)
03-05 23:55:08.154  1633  1664 W System.err: 	at org.mozilla.gecko.gfx.SurfaceAllocatorService$1.sync(SurfaceAllocatorService.java:54)
03-05 23:55:08.155  1633  1664 W System.err: 	at org.mozilla.gecko.gfx.ISurfaceAllocator$Stub.onTransact(ISurfaceAllocator.java:94)
03-05 23:55:08.155  1633  1664 W System.err: 	at android.os.Binder.execTransact(Binder.java:743)

It appears that webrender attaches the texture no matter the video element is displayed or not, while the old compositor only attaches the texture when video element is displayed.

[1] https://mdn.github.io/webgl-examples/tutorial/sample8/
[2] https://videojs-vr.netlify.com/

Comment 1

[John Lin [:jhlin][:jolin]]

Sotaro, do you know what changed there?

Comment 2

[Sotaro Ikeda [:sotaro]]

It seems like a regression of Bug 1594303.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1620458 - Revert part of Bug 1594303 fix

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a7f697e079db95b28d784fc342ec3978fee3953

Comment 5

[Kris Taeleman (:ktaeleman)]

@sotaro: Was this landed?

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Kris Taeleman (:ktaeleman) from comment #5)

@sotaro: Was this landed?

It is not landed yet, since there was another problem in the STR. Video frames were not rendered to WebGL. Auto video playback was blocked at IsGVAutoplayRequestAllowed. The problem could be bypassed by setting pref "media.geckoview.autoplay.request=false".

I updated a patch today. There was one assert failure. I am going to address the failure. Then I am going to ask review soon.

Comment 7

[Sotaro Ikeda [:sotaro]]

:jolin, IsGVAutoplayRequestAllowed() returned false with gecko_view example app, then video frames were not rendered to WebGL by default. Is it expected behavior?

Comment 8

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d62447ff5ebbce78952f4791f7a5bcbc2dd71e84

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e28a7b812a32
Revert part of Bug 1594303 fix r=nical

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e28a7b812a32

Comment 11

[John Lin [:jhlin][:jolin]]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)

:jolin, IsGVAutoplayRequestAllowed() returned false with gecko_view example app, then video frames were not rendered to WebGL by default. Is it expected behavior?

I think so. If autoplay is blocked, the video should not be played automatically without user action, and no video frame will be sent to the compositor in this case. Therefore no SurfaceTexture.updateTexImage() will be called and the texture WebGL gets is always empty.

Comment 12

[Laurentiu Apahidean]

Verified as fixed on Firefox Preview Nightly 200610 (Build #21620604) Wednesday 6/10 using a OnePlus 6T (Android 9) and Huawei MediaPad M3 (Android 7.0).