1620477 - (fission-crashtests) [meta] Fix crashtest fission failures

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P2)

Comment 1

[Timothy Nikkel (:tnikkel)]

Summary that I made for myself last week (so some of these could be fixed now) based on disabling tests so I could get a usable crashtest to test my reftest harness changes on try. Some of these have more than one failure mode/crash address and I include them all.

dom/base/crashtests/607222.html
crashes intermittently
application crashed [@ mozilla::dom::ClientSource::WindowExecutionReady(nsPIDOMWindowInner*)]

docshell/base/crashtests/1331295.html
consistently crashes
application crashed [@ mozilla::dom::ContentParent::RecvCacheBrowsingContextChildren(mozilla::dom::MaybeDiscarded<mozilla::dom::BrowsingContext> const&)]
Assertion failure: ChildID() == aBC->GetInFlightProcessId() (Attempt to modify a BrowsingContext from a child which doesn't own it), at /builds/worker/workspace/build/src/dom/ipc/ContentParent.cpp:5976
application crashed [@ mozilla::dom::ContentParent::CheckBrowsingContextOwnership(mozilla::dom::CanonicalBrowsingContext*, char const*) const]
[Child 1378, Main Thread] ###!!! ASSERTION: Overwriting an existing document channel!: '(loadFlags & nsIChannel::LOAD_REPLACE) || !(mDocumentRequest.get())', file /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp, line 428
[Child 1378, Main Thread] ###!!! ASSERTION: Wrong Document Channel: 'request == mDocumentRequest', file /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp, line 1500

dom/base/crashtests/610571-1.html
consistently crashes
application crashed [@ mozilla::dom::ContentParent::RecvAttachBrowsingContext(mozilla::dom::BrowsingContext::IPCInitializer&&)]

layout/generic/crashtests/471360.html
consistently crashes
application crashed [@ mozilla::dom::ClientSource::WindowExecutionReady(nsPIDOMWindowInner*)]
application crashed [@ mozilla::dom::ContentParent::RecvCacheBrowsingContextChildren(mozilla::dom::MaybeDiscarded<mozilla::dom::BrowsingContext> const&)]
Assertion failure: IsCurrentInnerWindow(), at /builds/worker/workspace/build/src/dom/base/nsGlobalWindowInner.cpp:5341
Assertion failure: !contentParent->IsDead(), at /builds/worker/workspace/build/src/dom/ipc/ContentParent.cpp:949
application crashed [@ nsGlobalWindowInner::SyncStateFromParentWindow()]
application crashed [@ mozilla::dom::ContentParent::GetNewOrUsedBrowserProcessAsync(mozilla::dom::Element*, nsTSubstring<char16_t> const&, mozilla::hal::ProcessPriority, mozilla::dom::ContentParent*, bool)]

layout/printing/crashtests/793844.html
pretty consistently either asserts or crashes
application crashed [@ mozilla::ProfilerParent::CreateForProcess(int)]
[Child 2666, Main Thread] ###!!! ASSERTION: Wrong Document Channel: 'request == mDocumentRequest', file /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp, line 1500
[Child 2666, Main Thread] ###!!! ASSERTION: Overwriting an existing document channel!: '(loadFlags & nsIChannel::LOAD_REPLACE) || !(mDocumentRequest.get())', file /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp, line 428

Comment 2

[Chris Peterson [:cpeterson]]

Thanks, Timothy! Fixing reproducible crashtest crashes will be a high priority for our Fission Nightly milestone (M6). I will file new blocking bugs for each of the test crashes you listed.

Comment 3

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly M6a. We need to enable Fission crashtests (as tier 1) soon.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #3)

We need to enable Fission crashtests (as tier 1) soon.

Enabling Fission crashtests is bug 1601782.

Comment 5

[Timothy Nikkel (:tnikkel)]

Try run seems green now
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff15e993e32e2f6c1965ab5e166edc7a3638c70d

Comment 6

[Matt Woodrow (:mattwoodrow)]

And tests are enabled now in bug 1601782!