1620500 - Remove BaseScript::isLazyScript flag

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

This flag was introduced to support Bug 1529456, but should be deprecated in favour of more specific feature tests (such as hasBytecode or hasEnclosingScope).

The majority of the remaining uses are in Zone::cellIter loops which should be using more specific differentiation between incomplete/hasEnclosingScript/hasEnclosingScope/hasBytecode.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620500 - Use more specific queries instead of BaseScript::isLazyScript

Replace uses of isLazyScript (which indicates the parser that generated it)
with more specific tests like hasBytecode or hasJitScript. Also move the
hasBaselineScript and hasIonScript accessors to BaseScript.

Depends on D66876

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620500 - Add BaseScript::isReadyForDelazification

This method indicates a BaseScript is "lazy" but has a valid enclosing scope
such that it could be compiled now. This is not true for lazy scripts with
lazy parent scripts.

Patch also cleans up the gc/PublicIterators to use this method and
hasBytecode instead of the general isLazyScript check.

Depends on D66881

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620500 - Remove BaseScript::IsLazyScript flag

Depends on D66882

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620500 - Remove JSScript::isUncompleted()

This method was checking for a specific partially initialized state. Replace
with checks for hasBytecode() instead (which ends up checking the same
fields).

Depends on D66883

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36d00c1d1a1f
Use more specific queries instead of BaseScript::isLazyScript r=jandem
https://hg.mozilla.org/integration/autoland/rev/98e520150cc8
Add BaseScript::isReadyForDelazification r=jandem
https://hg.mozilla.org/integration/autoland/rev/c8fb6eca7ad9
Remove BaseScript::IsLazyScript flag r=jandem
https://hg.mozilla.org/integration/autoland/rev/cc99b4449f14
Remove JSScript::isUncompleted() r=jandem

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/36d00c1d1a1f
https://hg.mozilla.org/mozilla-central/rev/98e520150cc8
https://hg.mozilla.org/mozilla-central/rev/c8fb6eca7ad9
https://hg.mozilla.org/mozilla-central/rev/cc99b4449f14