1620560 - Declare Blob/BaseBlobImpl::CreateInputStream const

Status: RESOLVED FIXED

(Core :: DOM: File, task, P3)

Description

[Simon Giesecke [:sg] [he/him]]

Blob/BaseBlobImpl::CreateInputStream seems to be possible to be declared const (except for the Debug flag in https://searchfox.org/mozilla-central/rev/49ed791eec93335abfe6c2880f84c324e73e47e6/dom/file/TemporaryFileBlobImpl.cpp#128, which can be declared mutable), so that callers are not forced to hold a non-const reference.

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1620560 - Part 1: Apply modernize-concat-nested-namespaces to dom/file r=smaug

D95456 didn't properly include headers (--header-filter=dom).

Depends on D145662

Comment 2

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1620560 - Part 2: readability-inconsistent-declaration-parameter-name to dom/file r=smaug

Depends on D145665

Comment 3

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1620560 - Part 3: Mark BlobImpl::CreateInputStream as const r=smaug

Depends on D145666

Comment 4

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1620560 - Part 4: Mark BlobImpl::GetFileId as const r=smaug

Depends on D145668

Comment 5

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1620560 - Part 5: Mark BlobImpl::CreateSlice as const r=smaug

Depends on D145669

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89ec09359f91
Part 1: Apply modernize-concat-nested-namespaces to dom/file r=smaug
https://hg.mozilla.org/integration/autoland/rev/d1bab5fc1b29
Part 2: readability-inconsistent-declaration-parameter-name to dom/file r=smaug
https://hg.mozilla.org/integration/autoland/rev/6d93b0262d5b
Part 3: Mark BlobImpl::CreateInputStream as const r=smaug
https://hg.mozilla.org/integration/autoland/rev/565c9fe03f68
Part 4: Mark BlobImpl::GetFileId as const r=smaug
https://hg.mozilla.org/integration/autoland/rev/33cf0d2db86d
Part 5: Mark BlobImpl::CreateSlice as const r=smaug

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/89ec09359f91
https://hg.mozilla.org/mozilla-central/rev/d1bab5fc1b29
https://hg.mozilla.org/mozilla-central/rev/6d93b0262d5b
https://hg.mozilla.org/mozilla-central/rev/565c9fe03f68
https://hg.mozilla.org/mozilla-central/rev/33cf0d2db86d