Closed Bug 1620560 Opened 4 years ago Closed 2 years ago

Declare Blob/BaseBlobImpl::CreateInputStream const

Categories

(Core :: DOM: File, task, P3)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: sg, Assigned: saschanaz)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Blob/BaseBlobImpl::CreateInputStream seems to be possible to be declared const (except for the Debug flag in https://searchfox.org/mozilla-central/rev/49ed791eec93335abfe6c2880f84c324e73e47e6/dom/file/TemporaryFileBlobImpl.cpp#128, which can be declared mutable), so that callers are not forced to hold a non-const reference.

Priority: -- → P3
Assignee: nobody → krosylight
Status: NEW → ASSIGNED

D95456 didn't properly include headers (--header-filter=dom).

Depends on D145662

Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/89ec09359f91
Part 1: Apply modernize-concat-nested-namespaces to dom/file r=smaug
https://hg.mozilla.org/integration/autoland/rev/d1bab5fc1b29
Part 2: readability-inconsistent-declaration-parameter-name to dom/file r=smaug
https://hg.mozilla.org/integration/autoland/rev/6d93b0262d5b
Part 3: Mark BlobImpl::CreateInputStream as const r=smaug
https://hg.mozilla.org/integration/autoland/rev/565c9fe03f68
Part 4: Mark BlobImpl::GetFileId as const r=smaug
https://hg.mozilla.org/integration/autoland/rev/33cf0d2db86d
Part 5: Mark BlobImpl::CreateSlice as const r=smaug
Regressions: 1768287
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: