We need to fix the callers of ThrowUserError so their strings get moved into the templates. (see also bug 162066.) Gerv
Keywords: patch, review
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 94762 [details] [diff] [review] Patch v.1 You left out Bugzilla/Search.pm. That code should probably return an error, rather than dump to a tempalte directly, but thats a separate issue Also, the " in the invalid_email_address thing should be "
Created attachment 95370 [details] [diff] [review] Patch v.2 Review comments addressed. Gerv
Attachment #94762 - Attachment is obsolete: true
Comment on attachment 95370 [details] [diff] [review] Patch v.2 Remove the default case at the end (or make it print a sensible internal error string), and r=bbaetz x2. I didn't test this, but it looks right, and I presume you have...
Attachment #95370 - Flags: review+
Fixed. Checking in CGI.pl; /cvsroot/mozilla/webtools/bugzilla/CGI.pl,v <-- CGI.pl new revision: 1.167; previous revision: 1.166 done Checking in duplicates.cgi; /cvsroot/mozilla/webtools/bugzilla/duplicates.cgi,v <-- duplicates.cgi new revision: 1.23; previous revision: 1.22 done Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.190; previous revision: 1.189 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.137; previous revision: 1.136 done Checking in template/en/default/global/messages.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v <-- messages.html.tmpl new revision: 1.5; previous revision: 1.4 done Checking in Bugzilla/Search.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v <-- Search.pm new revision: 1.5; previous revision: 1.4 done Gerv
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.